Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional round of lint cleanup #483

Merged
merged 26 commits into from
Apr 26, 2024
Merged

Additional round of lint cleanup #483

merged 26 commits into from
Apr 26, 2024

Conversation

Nitsirks
Copy link
Contributor

@Nitsirks Nitsirks commented Mar 27, 2024 •
edited
Loading

removed lint blackboxes
enabled TRNG files during lint runs
cleaned use of structs that violate unpacked struct usage
cast width of dynamic shifts to make lint happy
casting some arithmetic widths, math parameter widths
fixed enum ints to enum sized logic

Matthew Border and others added 3 commits March 1, 2024 17:04
Issue 445 LINT fixes
33d49ab
initial round of lint fixes
020cdc6
removing lint blackboxes
697a740 
removed packed struct post processing from generated reg files.
cast width of dynamic shifts to make lint happy
casting some arithmetic widths, math parameter widths etc
@mojtaba-bisheh
Copy link
Contributor

Does it merge with main? since LMS is in the main already but this PR does not include it

@Nitsirks
Copy link
Contributor Author

Does it merge with main? since LMS is in the main already but this PR does not include it

I have merged with main and I am running lint on that now. Will update shortly.

@calebofearth calebofearth mentioned this pull request Mar 30, 2024
Merged
This was referenced Apr 2, 2024
Merged
Merged
@Nitsirks Nitsirks mentioned this pull request Apr 3, 2024
Open
@calebofearth calebofearth mentioned this pull request Apr 25, 2024
Closed
@calebofearth calebofearth mentioned this pull request Apr 26, 2024
Closed
39 tasks
@calebofearth
MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/lint_fix' wi…
a597305 
…th updated timestamp and hash after successful run
@calebofearth
Copy link
Collaborator

@amullick007 @nstewart-amd

@amullick007
Copy link
Contributor

@amullick007 @nstewart-amd

Spyglass Lint is clean on this PR

@calebofearth
Copy link
Collaborator

@amullick007 @nstewart-amd

Spyglass Lint is clean on this PR

Excellent. Can you approve the PR so we can get it merged?

@amullick007
Copy link
Contributor

@amullick007 @nstewart-amd

Spyglass Lint is clean on this PR

Excellent. Can you approve the PR so we can get it merged?

Can you please add me as a reviewer to this PR?

@calebofearth
Copy link
Collaborator

@amullick007 @nstewart-amd

Spyglass Lint is clean on this PR

Excellent. Can you approve the PR so we can get it merged?

Can you please add me as a reviewer to this PR?

I am unable to add you for some reason, when I try to add your username I see this:
image
Perhaps you're not a member of the Caliptra team on this GitHub org?

@calebofearth calebofearth added the enhancement New feature or request label Apr 26, 2024
@calebofearth calebofearth merged commit c8aa467 into main Apr 26, 2024
55 checks passed
@amullick007
Copy link
Contributor

@amullick007 @nstewart-amd

Spyglass Lint is clean on this PR

Excellent. Can you approve the PR so we can get it merged?

Can you please add me as a reviewer to this PR?

I am unable to add you for some reason, when I try to add your username I see this: image Perhaps you're not a member of the Caliptra team on this GitHub org?

Not sure, anyway I am approving via this comment.

This was referenced Apr 30, 2024
Closed
Closed
Closed
Closed
Closed
@Nitsirks Nitsirks deleted the user/dev/michnorris/lint_fix branch June 6, 2024 18:27
@calebofearth calebofearth mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upadhyayulakiran upadhyayulakiran upadhyayulakiran approved these changes

@calebofearth calebofearth calebofearth approved these changes

@bharatpillilli bharatpillilli Awaiting requested review from bharatpillilli

@mojtaba-bisheh mojtaba-bisheh Awaiting requested review from mojtaba-bisheh

@mborder-amd mborder-amd Awaiting requested review from mborder-amd

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nitsirks @mojtaba-bisheh @calebofearth @amullick007 @upadhyayulakiran