Chore/update dependencies #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
reviewed
Jun 4, 2024
alerque
approved these changes
Jun 4, 2024
chevdor
reviewed
Jun 4, 2024
| env_logger = "0.10" | ||
| fluent-templates = { version = "0.8", optional = true, default-features = false, features = ["tera"]} | ||
| env_logger = "0.11" | ||
| fluent-templates = { version = "0.9", optional = true, default-features = false, features = ["tera", "use-ignore"] } |
There was a problem hiding this comment.
There are two features, use-ignore and walkdir, one of which must be enabled. The default feature list includes use-ignore, so this is not a change except that by dropping default features this dependency now doesn't need the macros feature to be compiled. I assume that was the point of this change...which makes sense since they are not being used in this context.
|
Great to see that this got merged so fast and a new release is available. Unfortunately, someone else got tagged in the 0.4.0 release notes as contributor - is it possible to adjust this? |
|
Oh yes sure, don't worry about that and sorry for the automation errors. I will adjust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update project dependencies specified in Cargo.toml,
cargo updateto generate new Cargo.lock fileMain reasons: