Implement auto fetch metadata (issue #9) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalanicolai
changed the title
dalanicolai
force-pushed
the
develop
branch
2 times, most recently
from
a5eb09d to
5a5f20b
Compare
Implement auto fetch data from Google and Amazon.com (currently requires Ivy)
Instead of the solution in PR chenyanming#8 of requiring multiple packages in calibredb-utils.el, I have moved the single function calibredb to calibredb.el. Besides that this fixes (recursive) autoload issues, this also fixes that that the :config block when defered loading of calibredb with use-package is evaluated (this is required for evilifying keybindings in the spacemacs layer). I presumed that defining the function calibredb directly in calibredb.el does not cause too much confusion. Finally I made calibredb-find-counsel autoloadable for which some packages are required from calibredb-ivy.el.
|
The last commit here replaces PR #8, because it fixes the autoloading issues there correctly (autoloading is required for the Spacemacs layer. It seems this last commit is merged within my previous PR to add auto fetch metadata functionality (I do not see how to seperate these PR's) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement and document issue #9 auto fetch metadata from Google and Amazon.com (currently requires Ivy).
TODO (after discussion)
I have implemented the last TODO point already. There is no option to choose between different sources for the covers (like in Calibre gui) because the calibredb wtih -c flag always downloads from the same source, no matter which plugin has been chosen to request the metadata.