Do not defrag and zerofill the disk twice during Windows cleanup and optimize #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add dco signoff to commits. Otherwise looks good to me. |
…optimize Signed-off-by: Matthew Bradbury <m.s.bradbury@lancaster.ac.uk>
|
Kudos, SonarCloud Quality Gate passed!
|
|
thanks for the contribution. |
hunleyd
added a commit
to hunleyd/bento
that referenced
this pull request
Sep 9, 2023
* 'main' of github.com:chef/bento: Keep linux-kernel-header package installed for Parallels builds (chef#1526) Update Ubuntu 22.04 `iso_url` (chef#1527) Do not defrag and zerofill the disk twice during Windows cleanup and optimize (chef#1525) Update vmware vars for el9 derivitives (chef#1519) Update Debian from 12.0 to 12.1 (https://www.debian.org/News/2023/20230722) (chef#1517) provision.ps1: fixed virtio-win-guest-tools.exe installation (chef#1516)
raykrist
pushed a commit
to norcams/bento
that referenced
this pull request
Aug 19, 2024
…optimize (chef#1525) Signed-off-by: Matthew Bradbury <m.s.bradbury@lancaster.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows cleanup.ps1 and optimize.ps1 scripts both conclude by defragging and zerofilling the disk. This change instead performs these actions only at the end of optimize.ps1.
Description
There are two advantages:
Related Issue
Types of changes
Checklist:
Will find some time over the next few days to do through the rest of the checklist. Is https://github.com/chef-cookbooks/community_cookbook_documentation/blob/main/TESTING.MD the correct guidance for pre-merge tests?