provision.ps1: fixed virtio-win-guest-tools.exe installation #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to execute \$guestToolsPath not \$guestTools. (\$guestTools is just an intermediate variable for setting \$guestToolsLog.) Newer virtio-win.iso has E:\virtio-win-guest-tools.exe. From the code it seems like older virtio-win.iso has this file in E:\driver. Made sure script works with both old and new virtio-win.iso. Signed-off-by: Zalan Bleneszy <zalan.blenessy@volvocars.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Stromweld
approved these changes
Jul 25, 2023
hunleyd
added a commit
to hunleyd/bento
that referenced
this pull request
Sep 9, 2023
* 'main' of github.com:chef/bento: Keep linux-kernel-header package installed for Parallels builds (chef#1526) Update Ubuntu 22.04 `iso_url` (chef#1527) Do not defrag and zerofill the disk twice during Windows cleanup and optimize (chef#1525) Update vmware vars for el9 derivitives (chef#1519) Update Debian from 12.0 to 12.1 (https://www.debian.org/News/2023/20230722) (chef#1517) provision.ps1: fixed virtio-win-guest-tools.exe installation (chef#1516)
raykrist
pushed a commit
to norcams/bento
that referenced
this pull request
Aug 19, 2024
Newer virtio-win.iso has E:\virtio-win-guest-tools.exe. From the code it seems like older virtio-win.iso has this file in E:\driver. Made sure script works with both old and new virtio-win.iso. Signed-off-by: Zalan Bleneszy <zalan.blenessy@volvocars.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to execute $guestToolsPath not $guestTools. ($guestTools is just an intermediate variable for setting $guestToolsLog.)
Newer virtio-win.iso has E:\virtio-win-guest-tools.exe. From the code it seems like older virtio-win.iso has this file in E:\driver. Made sure script works with both old and new virtio-win.iso.
Related Issue
Types of changes
Checklist: