Minor UI package maintenance #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
Jun 17, 2019
| @@ -10383,79 +10357,12 @@ | |||
| "path-is-absolute": "1.0.1" | |||
| } | |||
| }, | |||
| "har-schema": { | |||
There was a problem hiding this comment.
Interesting. I wonder what had dragged this in, and why it's gone now. 🤷♂
tarablack01
approved these changes
Jun 17, 2019
srenatus
suggested changes
Jun 19, 2019
Signed-off-by: michael sorens <msorens@chef.io>
Signed-off-by: michael sorens <msorens@chef.io>
Signed-off-by: michael sorens <msorens@chef.io>
msorens
force-pushed
the
ms/ui-package-maintenance
branch
from
fca5bb5
to
f55b996
Compare
srenatus
approved these changes
Jun 20, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
Starting to think about an Angular upgrade (Angular 8 just came out and we are still on Angular 6).
Ran into various issues when attempting to upgrade that need more investigation, but this PR is at least a start to tidy up a couple minor things.
Upon upgrading
tslinta few new linting errors appeared, and this PR resolves them.Error: Tried to lint file.js but found no valid, enabled rules for this file type and file path in the resolved configuration. The fix for that is to add a
jsRulessection to the tslint.json file, as described here: No valid rules have been specified palantir/tslint#3735The recommended content of the
jsRulesection from that suggested fix--to turn on the "no empty blocks" rule caused, a few instances of, yep (block is empty). It turns out that the content of thatjsRulesfor the first fix is completely arbitrary; any rule will do, so I changed that to something innocuous (no-debugger), and that resolved this second issue.Error: no-use-before-declare is deprecated. This refers to a linting rule in tslint.json that is both expensive to compute and not at all needed in a ts application (would be in a plain js application). So just deleting that line from the config in tslint.json was the fix here. Reference: https://palantir.github.io/tslint/rules/no-use-before-declare/
👍 Definition of Done
👟 Demo Script / Repro Steps
⛓️ Related Resources
✅ Checklist