Ignore colons inside of url(.*) when parsing css

[Meekohi]

Parsing by css is totally wrong, but this will at least not break on url(http://whatever); anymore! Closes issue #315.

[jugglinmike]

Hi Michael,

Thanks for the pull request! This approach address the problem, but it also seems a bit heavy for the problem at hand. If we use String.prototype.indexOf to find the first occurrence of the : character (and then slice or substr with that), we don't have to worry about parsing CSS values, and we can avoid the overhead of compiling and matching against a regular expression.

What do you say? If you're up for it, could you also add a unit test to test/api.css.js for this to help us avoid regressions?

[matthewmueller]

Thanks for catching this @Meekohi. +1 to @jugglinmike's suggestion.

[Meekohi]

@jugglinmike I like it, makes sense as a speed optimization. I'll write a test for it and update this pull request soon.

[Meekohi]

@matthewmueller and @jugglinmike this should do the trick and still be very fast. Have a look.

[jugglinmike]

Ah, you've found (and fixed) another bug! Could you extend your test to verify that we're doing this correctly?

Some code style changes:

• Could you place the comment on the preceding line--we try to stay under 80 characters in the source files.
• Could you insert a space between the if keyword and the open parenthesis (() character?

[Meekohi]

Added two more regression tests to make sure parse("color:")=={} and parse(":#ccc")=={}. I think this should be ready to pull in now.

[jugglinmike]

Merged to master at commit a785c52 . Thanks, Michael!

[chiqui3d]

is still not working for mi case #1223