Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS parsing does not handle url(http://foo); correctly #315

Closed
Meekohi opened this issue Dec 3, 2013 · 1 comment
Closed

CSS parsing does not handle url(http://foo); correctly #315

Meekohi opened this issue Dec 3, 2013 · 1 comment

Comments

@Meekohi
Copy link
Contributor

Meekohi commented Dec 3, 2013

If your element has background-image: url(http://foo.com/image.jpg); cheerio will parse it as {'background-image':'http'} due to splitting on the : character.
Meekohi added a commit to Meekohi/cheerio that referenced this issue Dec 3, 2013
@Meekohi
Ignore colons inside of url(.*) when parsing css
0b8978a 
Parsing by css is totally wrong, but this will at least not break on `url(http://whatever);` anymore! Closes issue cheeriojs#315.
@Meekohi Meekohi mentioned this issue Dec 3, 2013
Closed
jugglinmike pushed a commit that referenced this issue Dec 5, 2013
@Meekohi @jugglinmike
Ignore colons inside of url(.*) when parsing css
a785c52 
Parsing by css is totally wrong, but this will at least not break on `url(http://whatever);` anymore! Closes issue #315.
@jugglinmike
Copy link
Member

Resolved in #316 .

@carrieje carrieje mentioned this issue Jan 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Meekohi @jugglinmike