Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devfile): Introduce a devfile version2 #2

Merged
merged 2 commits into from
Sep 27, 2021
Merged

feat(devfile): Introduce a devfile version2 #2

merged 2 commits into from
Sep 27, 2021

Conversation

svor
Copy link
Contributor

@svor svor commented Sep 24, 2021

Signed-off-by: svor vsvydenk@redhat.com

Provides devfile v2 with ms-python.python extension
screenshot-192 168 49 2 nip io-2021 09 24-15_31_46

Signed-off-by: svor <vsvydenk@redhat.com>
Copy link

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you avoid next tag as it may break this sample

Also you could give a try on quay.io/devfile/base-developer-image:ubi8-7bd4fe3

devfile.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,24 @@
schemaVersion: 2.1.0
metadata:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's missing the attribute to deploy extensions in the user container ?

Copy link
Contributor Author

@svor svor Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sidecar image is a bit different then user container image. So what is the right way: deploy extension to the sidecar container or modify user container image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for DevWorkspaces, default is to have extensions running in the user container (no longer need to bring the sidecar image)

So it should work with the universal devfile base image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it can be a step 2 (use sidecar image as user image) or step 3 (use universal base image) eclipse-che/che#20507

but as we're moving to it, it may be a good step to report issues on devfile base image if it doesn't work well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribute was added. For this devfile we can use the universal base image.
But for another python samples we probably will need some additional tools/libraries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will know about that a bit later :-)

Signed-off-by: svor <vsvydenk@redhat.com>
@svor svor merged commit d71b91e into che-samples:devfilev2 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants