-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devfile): Introduce a devfile version2 #2
Conversation
Signed-off-by: svor <vsvydenk@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you avoid next
tag as it may break this sample
Also you could give a try on quay.io/devfile/base-developer-image:ubi8-7bd4fe3
@@ -0,0 +1,24 @@ | |||
schemaVersion: 2.1.0 | |||
metadata: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's missing the attribute to deploy extensions in the user container ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sidecar image is a bit different then user container image. So what is the right way: deploy extension to the sidecar container or modify user container image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ @benoitf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for DevWorkspaces, default is to have extensions running in the user container (no longer need to bring the sidecar image)
So it should work with the universal devfile base image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it can be a step 2 (use sidecar image as user image) or step 3 (use universal base image) eclipse-che/che#20507
but as we're moving to it, it may be a good step to report issues on devfile base image if it doesn't work well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attribute was added. For this devfile we can use the universal base image.
But for another python samples we probably will need some additional tools/libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will know about that a bit later :-)
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor vsvydenk@redhat.com
Provides devfile v2 with ms-python.python extension
