Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of the devfile universal images in Che samples #20507

Closed
6 of 8 tasks
benoitf opened this issue Sep 22, 2021 · 1 comment
Closed
6 of 8 tasks

Use of the devfile universal images in Che samples #20507

benoitf opened this issue Sep 22, 2021 · 1 comment
Labels
area/devfile-registry area/plugins area/samples engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. roadmap/3-months Epics that are planned to complete in the short term (within 3 months) severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Sep 22, 2021

Is your enhancement related to a problem? Please describe

  • The number of images to maintain: we have almost a distinct image for each of our samples and plugins
  • We do not have a default image for component-less workspaces (we currently use Theia sidecar, that’s ok for nodejs but for the rest?)
  • To cache our sample images for faster startup we need to pre-pull 20+ images on every single node of the cluster
  • Developers should not leave a workspace to use a command line tool (for example while coding in Java a developer may want use python or kubectl)
  • The images for the samples and plugins need to be kept in sync

image

Describe the solution you'd like

  • Define a Universal Developer Image that include every tool required
    • by the commands in our samples
    • by the vs extensions included in our samples
    • by the top 10 VS Code extensions in the marketplace
  • Use the Universal Developer image as the main component of every sample devfile
  • When Theia is the editor: run the extensions in the main devfile component
  • When VS Code is the editor: run both the editor and the extensions in the main devfile component
  • When IntelliJ is the editor: run the editor in the main devfile component

image

Additional context

We should update only Devfile v2 examples
We should continue to build the plugins sidecar images for when the developer specify sidecar-policy: MERGE_IMAGE

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. area/devfile-registry area/plugins area/samples area/devfile-spec Issues related to Devfile v2 labels Sep 22, 2021
@benoitf benoitf changed the title Use the devfile universal images Use of the devfile universal images Sep 22, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 22, 2021
@benoitf benoitf added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 22, 2021
@sleshchenko sleshchenko added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. and removed area/devfile-spec Issues related to Devfile v2 labels Sep 28, 2021
@l0rd l0rd added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. roadmap/3-months Epics that are planned to complete in the short term (within 3 months) labels Sep 29, 2021
@l0rd l0rd changed the title Use of the devfile universal images Use of the devfile universal images in Che samples Oct 4, 2021
@che-bot
Copy link
Contributor

che-bot commented Jul 5, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2022
@che-bot che-bot closed this as completed Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry area/plugins area/samples engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. roadmap/3-months Epics that are planned to complete in the short term (within 3 months) severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants