Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable example workspaces to upgrade to gazelle 0.33.0 #589

Closed
cgrindel opened this issue Sep 14, 2023 · 1 comment · Fixed by #588
Closed

Enable example workspaces to upgrade to gazelle 0.33.0 #589

cgrindel opened this issue Sep 14, 2023 · 1 comment · Fixed by #588
Assignees
@cgrindel
Labels
chore Developer chore or clean up

Comments

@cgrindel
Copy link
Owner

Several Renovate PRs are unable to merge: #485, #486, #569, #579. There are a few issues entangled together:

  • The experimental API for slices.SortFunc() changed.
  • The bazel-gazelle 0.33.0 is missing some Starlark declarations which causes Stardoc to fail in this repo. This has been fixed.
  • Waiting on a new bazel-gazelle release with the Starlark declaration fix.

WIP PR: #588
@cgrindel cgrindel added the chore Developer chore or clean up label Sep 14, 2023
@cgrindel cgrindel self-assigned this Sep 14, 2023
@cgrindel cgrindel mentioned this issue Sep 14, 2023
Merged
@cgrindel
Copy link
Owner Author

cgrindel commented Nov 9, 2023

bazel-gazelle released 0.34.0.

Unfortunately, I am running into an issue fixed by this rules_go PR. The latest rules_go release, 0.42.0, does not contain the fix.

cgrindel added a commit that referenced this issue Nov 23, 2023
@cgrindel
chore: upgrade gazelle to 0.34.0 and rules_go to 0.43.0 (#588)
3981077 
Closes #589.

---------

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgrindel cgrindel

Labels
chore Developer chore or clean up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade gazelle to 0.34.0 and rules_go to 0.43.0 cgrindel/rules_swift_package_manager
1 participant
@cgrindel