Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CFPB Design System 3.0 #47

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Upgrade to CFPB Design System 3.0 #47

merged 1 commit into from
Sep 3, 2024

Conversation

chosak
Copy link
Member

@chosak chosak commented Aug 26, 2024

This PR upgrades the CFPB Design System to version 3.0.x. It drops use of Avenir Next in favor of Arial.

To test, try yarn watch and visit http://localhost:8080.

See #46 and https://github.local/Design-Development/Design-and-Content-Team/issues/502 for context.

Notes

Compilation produces the following warning:

(node:41667) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
(Use node --trace-deprecation ... to show where the warning was created)

This is due to this line in the nunjucks-webpack-plugin plugin used by this repository. Unfortunately that package seems abandoned; it would be better long-term to migrate this website to esbuild and some other templating strategy. For now this is the minimal change needed to migrate to DS v3.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Passes all existing automated tests

@chosak chosak requested a review from anselmbradford August 26, 2024 21:48
@chosak chosak mentioned this pull request Aug 26, 2024
5 tasks
@chosak chosak requested a review from contolini August 27, 2024 13:52
Copy link
Member

@anselmbradford anselmbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! 👍 THANKS!!

@chosak chosak merged commit 6b9d758 into main Sep 3, 2024
1 check passed
@chosak chosak deleted the upgrade/ds-3.0.0 branch September 3, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants