Drop old URLs from dashboard report #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how Webpack is used to generate the Lighthouse dashboard, so that it drops old URLs that were tested in previous nightly runs but weren't tested in the latest run.
This doesn't remove those old reports from the repository, or from the singular reports.json file that we generate that aggregates all of the reports -- it only modifies how the dashboard website is built to exclude those results from the dashboard.
See internal https://github.local/Design-Development/Design-and-Content-Team/issues/502 for context.
I've also updated the linter config for this repo by copying the settings from https://github.com/cfpb/design-system, and cleaned up some old font files that somehow got built up over time.
Testing
Pull down this repository then run
yarn && yarn serve
and you'll see that your local http://127.0.0.1:8080/ server excludes URLs that aren't in the most recent test set (compare against https://cfpb.github.io/cfgov-lighthouse/).Todos
There may be a nicer way to write the JS to implement the desired logic; @anselmbradford @contolini please feel free to school me if so.
Checklist