Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: update PR template with new checklist item and helpful links #809

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

phlogistonjohn
Copy link
Collaborator

Add a new checklist item reminding contributors to run make api-update to track new APIs. Add two short paragraphs that cover some of the common things I copy and paste or need to look up when working with contributors' PRs.

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Jan 9, 2023
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

See below for a small suggestion.

.github/pull_request_template.md Outdated Show resolved Hide resolved
anoopcs9
anoopcs9 previously approved these changes Jan 11, 2023
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

Add a new checklist item reminding contributors to run `make
api-update` to track new APIs. Add two short paragraphs that
cover some of the common things I copy and paste or need to look up
when working with contributors' PRs.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify
Copy link

mergify bot commented Jan 11, 2023

rebase

✅ Branch has been successfully rebased

@mergify mergify bot dismissed anoopcs9’s stale review January 11, 2023 05:38

Pull request has been modified.

@mergify mergify bot merged commit 5e369f2 into ceph:master Jan 11, 2023
@phlogistonjohn phlogistonjohn deleted the jjm-pr-template-1 branch January 23, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants