Skip to content

Commit

Permalink
github: update PR template with new checklist item and helpful links
Browse files Browse the repository at this point in the history
Add a new checklist item reminding contributors to run `make
api-update` to track new APIs. Add two short paragraphs that
cover some of the common things I copy and paste or need to look up
when working with contributors' PRs.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
  • Loading branch information
phlogistonjohn authored and mergify[bot] committed Jan 11, 2023
1 parent a6a42e9 commit 5e369f2
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,16 @@ Thank you for opening a pull request. Please provide:
- [ ] Public functions and types are documented
- [ ] Standard formatting is applied to Go code
- [ ] Is this a new API? Added a new file that begins with `//go:build ceph_preview`
- [ ] Ran `make api-update` to record new APIs

New or infrequent contributors may want to review the go-ceph [Developer's
Guide](https://github.com/ceph/go-ceph/blob/master/docs/development.md)
including the section on how we track [API
Status](https://github.com/ceph/go-ceph/blob/master/docs/development.md#api-status)
and the [API Stability
Plan](https://github.com/ceph/go-ceph/blob/master/docs/api-stability.md).

The go-ceph project uses mergify. View the [mergify command
guide](https://docs.mergify.com/commands/#commands) for information on how to
interact with mergify. Add a comment with `@Mergifyio` `rebase` to rebase your
PR when github indicates that the PR is out of date with the base branch.

0 comments on commit 5e369f2

Please sign in to comment.