Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow for existing pytest tests #165

Merged
merged 1 commit into from
Aug 8, 2023
Merged

CI workflow for existing pytest tests #165

merged 1 commit into from
Aug 8, 2023

Conversation

baum
Copy link
Collaborator

@baum baum commented Jul 23, 2023

CI workflow for existing pytest tests

The idea is to incorporate the current pytest suite into the GitHub CI workflow, ensuring the continuous validation of both the evolving codebase and the tests themselves, which have tendency to rot if not used.

extracted from:

Multi-job workflow

A single workflow with a common build images job, using GitHub artifacts to share the container images between the jobs.

graph LR
    B(build) -->D[demo]
    B -->P[pytest matrix]
    P-->C(cli)
    P-->S(state)
    P-->M(multi gateway)
Loading

@baum baum mentioned this pull request Jul 23, 2023
@baum baum requested review from epuertat and sskaur July 24, 2023 07:25
.github/workflows/build-container.yml Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
mk/containerized.mk Outdated Show resolved Hide resolved
mk/containerized.mk Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
ceph-nvmeof.conf Show resolved Hide resolved
@baum baum force-pushed the pytest branch 8 times, most recently from e5be9de to 87e6856 Compare July 24, 2023 13:03
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @baum! LGTM 👍🏼. I still have some concerns, but it's totally acceptable that they can be addressed in a follow-up PR 😉

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
@baum baum force-pushed the pytest branch 6 times, most recently from 4ebdf27 to 4c3af0b Compare August 1, 2023 23:36
@baum baum force-pushed the pytest branch 3 times, most recently from f4dc04d to 1cc3c04 Compare August 7, 2023 10:50
@baum baum force-pushed the pytest branch 4 times, most recently from 9f37413 to 4a9198f Compare August 7, 2023 13:43
Copy link
Collaborator

@barakda barakda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baum baum force-pushed the pytest branch 3 times, most recently from 19a490c to 2fbb943 Compare August 7, 2023 21:10
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor change request. Once amended, we can merge this (required CI is temporarily disabled).

- extracted from: https://github.com/baum/ceph-nvmeof/tree/build-container-ci

Multi-stage workflow with a common build job, sharing images using GitHub artifacts

Co-authored-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
@baum baum merged commit a49e86b into ceph:devel Aug 8, 2023
@baum baum mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants