-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI workflow for existing pytest tests #165
Conversation
e5be9de
to
87e6856
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @baum! LGTM 👍🏼. I still have some concerns, but it's totally acceptable that they can be addressed in a follow-up PR 😉
4ebdf27
to
4c3af0b
Compare
f4dc04d
to
1cc3c04
Compare
9f37413
to
4a9198f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
19a490c
to
2fbb943
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a minor change request. Once amended, we can merge this (required CI is temporarily disabled).
- extracted from: https://github.com/baum/ceph-nvmeof/tree/build-container-ci Multi-stage workflow with a common build job, sharing images using GitHub artifacts Co-authored-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com> Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
CI workflow for existing pytest tests
The idea is to incorporate the current pytest suite into the GitHub CI workflow, ensuring the continuous validation of both the evolving codebase and the tests themselves, which have tendency to rot if not used.
extracted from:
Multi-job workflow
A single workflow with a common build images job, using GitHub artifacts to share the container images between the jobs.