Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹Containerized CI tests #134

Closed
wants to merge 2 commits into from
Closed

Conversation

baum
Copy link
Collaborator

@baum baum commented May 19, 2023

Initial containers tests

Signed-off-by: Alexander Indenbaum aindenba@redhat.com

@baum baum force-pushed the build-container-ci branch 2 times, most recently from c88628c to 09750be Compare May 22, 2023 09:33
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, @baum! Just left some ideas over there. Plz let me know what you think about those! Thanks!

.github/workflows/build-container.yml Outdated Show resolved Hide resolved
.github/workflows/build-container.yml Outdated Show resolved Hide resolved
.github/workflows/pytest_cli.yml Outdated Show resolved Hide resolved
.github/workflows/pytest_multi_gateway.yml Outdated Show resolved Hide resolved
Dockerfile.ceph Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
@baum baum force-pushed the build-container-ci branch 4 times, most recently from 2cb8d55 to 223d1c7 Compare May 22, 2023 13:07
@baum baum force-pushed the build-container-ci branch 7 times, most recently from a8b924c to 86af1a6 Compare May 23, 2023 12:59
control/cli.py Show resolved Hide resolved
control/cli.py Outdated Show resolved Hide resolved
@baum baum force-pushed the build-container-ci branch 3 times, most recently from 9833e2f to 1f0c454 Compare May 23, 2023 18:40
@baum baum force-pushed the build-container-ci branch 5 times, most recently from 8ef15ab to 49002e1 Compare May 24, 2023 06:55
@epuertat epuertat mentioned this pull request May 24, 2023
@baum baum force-pushed the build-container-ci branch from 49002e1 to a679941 Compare May 30, 2023 06:56
@epuertat epuertat mentioned this pull request May 30, 2023
19 tasks
@baum baum force-pushed the build-container-ci branch from a679941 to aa8a6d2 Compare May 30, 2023 09:41
- [x] Containerize and isolate spdk build (ubi8 and ubi9)
- [x] Containerize nvme-of build (ubi9)
- [x] Manage Python package dependencies and metadata (pdm)
- [x] Remove dependencies from /usr/libexec (since those are not intended
  for external usage).
- [x] Simplify build & deployment (docker-compose instead of make)
- [x] Add containerized Ceph cluster
- [x] Update Makefile
- [x] Update docs

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
@baum baum force-pushed the build-container-ci branch from aa8a6d2 to bb994d9 Compare June 19, 2023 06:44
- Workaround, see  spdk/spdk#2731
- Readme CLI example test
- Address issue: ceph#135
- CLI process exit with error code in case of exception: ceph#137
- Workflows for existing pytest tests using matrix model

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
@baum
Copy link
Collaborator Author

baum commented Jul 23, 2023

Mostly merged in #90
Remaining parts extracted into

@baum baum closed this Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

cli: return non-zero status on command failure, and output clean-up cli: add specific configuration
2 participants