This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Mon 3204 enable session cookie strict mode #7892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kduret
approved these changes
Oct 2, 2019
ganoze
reviewed
Oct 2, 2019
Co-Authored-By: Matthieu Kermagoret <mkermagoret@centreon.com>
ganoze
suggested changes
Oct 2, 2019
ganoze
reviewed
Oct 2, 2019
ganoze
approved these changes
Oct 2, 2019
sc979
added a commit
that referenced
this pull request
Oct 2, 2019
* fix(secu): enable session cookie strict mode * fix(secu): destroy session cookie at logout * enh(BE): correct variable name * enh(BE): correct variable name and optim condition * enh(BE): correct variable name * enh(secu): remove all saved session of the disconnected user * restore multi users current session management * enh(BE): moving the session parameters in the php.ini * fix(secu): regenerate session id after login * enh(BE): remove the forced deletion of the cookie * fix(secu): session fixation for the image generation autologin process * fix(secu): activate the delete_old_sid param
sc979
added a commit
that referenced
this pull request
Oct 2, 2019
* fix(secu): enable session cookie strict mode * fix(secu): destroy session cookie at logout * enh(BE): correct variable name * enh(BE): correct variable name and optim condition * enh(BE): correct variable name * enh(secu): remove all saved session of the disconnected user * restore multi users current session management * enh(BE): moving the session parameters in the php.ini * fix(secu): regenerate session id after login * enh(BE): remove the forced deletion of the cookie * fix(secu): session fixation for the image generation autologin process * fix(secu): activate the delete_old_sid param
|
this pull break my app Droideon because of regenerations of cookies |
|
Hi @jeromedevel , As you can see in the Owasp resources : https://cheatsheetseries.owasp.org/cheatsheets/Session_Management_Cheat_Sheet.html ; If you need help to fix your application, you need to help us understand how and when, your app is using the sessionId. Regards |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Securing the PHPSESSID cookie from hijack or modifications using the session.strict_mode in the php.ini (these modifications have been removed from current PR; and already merged on centreon-build to be deployed with the next RPMs).
Regenerating the session_id() value after the login and after the logout
Minor typo and variable naming corrections
Fixes # (none)
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
-> Please contact me
Checklist
Community contributors & Centreon team
Centreon team only