Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Session fixation fix #7789

Closed
wants to merge 9 commits into from
Closed

Session fixation fix #7789

wants to merge 9 commits into from

Conversation

miteto
Copy link
Contributor

@miteto miteto commented Aug 21, 2019

Session fixation fix

Description

check for valid session ID before inserting it into session table

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

www/include/core/login/processLogin.php Outdated Show resolved Hide resolved
@sc979 sc979 requested a review from callapa August 21, 2019 12:00
www/include/core/login/processLogin.php Outdated Show resolved Hide resolved
www/include/core/login/processLogin.php Outdated Show resolved Hide resolved
@sc979 sc979 force-pushed the MON-3204-session-fixation branch from 81804a2 to 42def03 Compare September 27, 2019 14:57
@sc979 sc979 force-pushed the MON-3204-session-fixation branch from 7bb3334 to bbd85eb Compare September 30, 2019 09:33
@sc979
Copy link
Contributor

sc979 commented Oct 1, 2019

as the cookie is still vulnerable. I close this PR, which is replaced by this one : https://github.com/centreon/centreon/pull/7892

@sc979 sc979 closed this Oct 1, 2019
@sc979 sc979 deleted the MON-3204-session-fixation branch October 7, 2019 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants