Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Correction on custom view using spanish #7778

Merged
merged 5 commits into from
Aug 28, 2019

Conversation

adrien2612
Copy link
Contributor

@adrien2612 adrien2612 commented Aug 13, 2019

Pull Request Template

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@lpinsivy
Copy link
Contributor

@adrien2612 you can compile and test your translation on a Centreon using

msgfmt messages.po -o messages.mo
cp messages.mo /usr/share/centreon/www/locale/es_ES.UTF-8/LC_MESSAGES/messages.po
chown apache:apache /usr/share/centreon/www/locale/es_ES.UTF-8/LC_MESSAGES/messages.po
systemctl restart httpd24-httpd

Copy link
Contributor

@lpinsivy lpinsivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double msgstr for 1 msgid is not correct

lang/es_ES.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
lang/es_ES.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
lang/es_ES.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
lang/es_ES.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
@adrien2612 adrien2612 requested review from sc979 and lpinsivy August 20, 2019 14:08
aclotudrzal and others added 5 commits August 22, 2019 11:09
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
Co-Authored-By: sc979 <34628915+sc979@users.noreply.github.com>
@adr-mo adr-mo force-pushed the MON-4089-error-on-custom-view-using-spanish branch from 33e3aa3 to e5b8304 Compare August 22, 2019 09:10
@kduret kduret merged commit 7ebe338 into master Aug 28, 2019
@kduret kduret deleted the MON-4089-error-on-custom-view-using-spanish branch August 28, 2019 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants