fix(monitoring filters): status filter dropdown doesn't lose it's value #7339
Conversation
- check dropdown from $_GET parameters and use it - remove duplicated parameters from form - check if parameter is string when adding it to parameters in URL (for redirecting)
| @@ -554,6 +556,9 @@ function preInit() { | |||
| jQuery("#statusService option[value='svc_unhandled']").prop('selected', true); | |||
| jQuery("#statusFilter option[value='']").prop('selected', true); | |||
| } | |||
| if(_defaultStatusFilter != '') { | |||
There was a problem hiding this comment.
please add a space after the "if" : if( -> if (
| @@ -528,6 +529,7 @@ function preInit() { | |||
| _sid = '<?php echo $sid ?>'; | |||
| _tm = <?php echo $tM ?>; | |||
| _o = '<?php echo $o; ?>'; | |||
| _defaultStatusFilter = '<?php echo $defaultStatusFilter; ?>'; | |||
There was a problem hiding this comment.
why don't you use <?= instead of <?php echo ?
There was a problem hiding this comment.
because other (above) assignments were that way
|
I thought this would also solve issue explained in https://github.com/centreon/centreon/issues/7306#issuecomment-475951673 |
|
I close this PR, as the work isn't ready to be reviewed properly, nor tested |
|
Issue #7306 not resolved. I have upgrade to 2.8.28 and the problem appear again. |
|
Hi @ptitpopey , As you can see :
As you know, we don't fix the 2.8.x based on PHP5 anymore, except for security fixes. Could you consider to upgrade your Centreon to the latest version ? Regards, |
Fix monitoring services filter
status filter dropdown doesn't lose it's value
Type of change
Target serie