Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(topology) Correct URL options for service pages #7327

Closed
wants to merge 13 commits into from
Closed

fix(topology) Correct URL options for service pages #7327

wants to merge 13 commits into from

Conversation

UrBnW
Copy link
Contributor

@UrBnW UrBnW commented Mar 22, 2019

Hi,

Description

This PR closes #6162, where the default "Display details" filter set to Problems is not enforced in Moniotring Services views.

Type of change

  • Patch fixing an issue (non-breaking change)

Target serie

Please delete series that are not relevant.

  • 20.04.x (master)

How this pull request can be tested ?

Go to Monitoring / Status Detail / Services grid
Go to Monitoring / Status Detail / Services by Hostgroups
Go to Monitoring / Status Detail / Services by Servicegroups

And verify that the default "Display details" filter set to Problems is correctly active.

Edit : issue still present in 19.10.3.

@adr-mo
Copy link
Contributor

adr-mo commented Apr 1, 2019

Hi @cpbn,

Thanks for the contribution 💯

We'll try to make your work happen in Centreon as soon as possible 👍

Regards,

@UrBnW
Copy link
Contributor Author

UrBnW commented Apr 30, 2019

Rebased for 19.04.1.
@lpinsivy Laurent could we then think about adding this tiny PR to the 19.04.1 project please, so that I don't have to change SQL filename on every release ? :)
Many thanks 👍

@adr-mo
Copy link
Contributor

adr-mo commented Apr 30, 2019

Hi @cpbn

I'll request some reviews for this PR so that we can start the validation on it :)

@lpinsivy I am adding this to the 19.04.1

Regards,

@adr-mo adr-mo requested review from sc979 and kduret April 30, 2019 14:42
@UrBnW
Copy link
Contributor Author

UrBnW commented Apr 30, 2019

Hi @adr-mo, and thank you very much !

@UrBnW
Copy link
Contributor Author

UrBnW commented Jun 4, 2019

@adr-mo, sounds like this has been moved to DONE status without having been implemented ? :-|
Thank you !

@UrBnW
Copy link
Contributor Author

UrBnW commented Jun 24, 2019

For info this fix was already pushed in Centreon 2.7.1 : Update-DB-2.7.1.sql.
Unfortunately, insertTopology.sql was not updated at the same time.
This is what this PR does.

@sc979
Copy link
Contributor

sc979 commented Jun 25, 2019

@adr-mo , forking, rebasing and launching a job on the CI for you to be able to test TNR ;)
check branch :
CPbN-fix-topology-url-for-service-pages

@sc979
Copy link
Contributor

sc979 commented Jun 25, 2019

I resolved conflict and updated the SQL upgrade script to 18.10.x and 19.04 branches

@UrBnW UrBnW requested review from kduret and sc979 October 4, 2019 09:47
@UrBnW
Copy link
Contributor Author

UrBnW commented Oct 29, 2019

Rebased for master / 20.04.0-beta.1.

@UrBnW
Copy link
Contributor Author

UrBnW commented Nov 7, 2019

Just rebased again.
@kduret could you please re-approve this so that we can move on ?
Thank you !

@adr-mo
Copy link
Contributor

adr-mo commented Nov 7, 2019

Hi @cpbn
I'll create a branch from Centreon repository with your work for building / validation matters.
In fact the build of your work fails on our acceptance tests but it is not related to your work ;)

This will avoid to ask you to rebase your work everytime some changes are pushed on master.

I'll let you know when the validation is done, and your work merged :)

Thanks again for the contribution 💯

@adr-mo
Copy link
Contributor

adr-mo commented Nov 7, 2019

Branch created MON-4140-topology-services-issue and currently being built :)

@adr-mo
Copy link
Contributor

adr-mo commented Nov 28, 2019

@cpbn PR created above yours so that we can easily validate it :)

@UrBnW
Copy link
Contributor Author

UrBnW commented Nov 28, 2019

Good news, many thanks @adr-mo 👍
Glad to see it almost landed 😉

@UrBnW UrBnW closed this Nov 28, 2019
@UrBnW UrBnW deleted the topology branch November 28, 2019 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services Grid, Services by (host|service)groups display "All" instead of "Problems" as the filter suggests
4 participants