This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
fix(install): Remove obsolete rrdtool configuration and sources #7195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lpinsivy
commented
Feb 15, 2019
- Remove unused PHP sources
- Remove unused options in "Administration > Parameters > RRDTool" menu
- Clean centreon.options table for update (no entries during installation)
sc979
reviewed
Feb 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we remove translations texts from the pot files too ?
@sc979 it will be removed automatically next time we will update translation. |
sc979
approved these changes
Feb 18, 2019
This was referenced Mar 12, 2019
Co-Authored-By: lpinsivy <lpinsivy@gmail.com>
lpinsivy
force-pushed
the
remove-obsolete-rrdtool-configuration
branch
from
April 2, 2019 12:53
459d0b0
to
b7a9b01
Compare
Rebase branch originally from 18.10.x to master and merge conflicts |
callapa
approved these changes
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.