MON-3518-filter-correction-recurrent-downtime-form #6509
Conversation
| @@ -46,6 +46,9 @@ | |||
| if (isset($_POST['searchDT']) && $_POST['searchDT']) { | |||
| $search = $_POST['searchDT']; | |||
| $downtime->setSearch($search); | |||
| } elseif (isset($_GET['search']) && $_GET['search'] && !isset($_POST['searchDT'])) { | |||
There was a problem hiding this comment.
Why do you use search parameter ?
The good one is searchDT, so you can remove those lines.
sc979
force-pushed
the
jben94-Fix-Pag-ReccurDowntime
branch
from
2fa9127 to
0f92657
Compare
|
@sc979 Could you please change the base for the PR from 2.8.x to master/18.10.x and rebase the branch. |
|
no I can't. This PR is specific to the 2.8.x as we PEAR methods were replaced with PDOs' |
|
@sc979 I guess this one can be transformed only for master and 18.10.x branches. No more bugfixes will be merged on the 2.8.x except critical/blocking bugs and security fixes |
|
@adr-mo ok, I'll adapt it ASAP ;) |
|
on 2.8.x too please |
lpinsivy
added
the
status/in-backlog
sc979
force-pushed
the
jben94-Fix-Pag-ReccurDowntime
branch
from
0f92657 to
1d2fe75
Compare
sc979
changed the title
|
the PR for the 18.10.x is here : |
sc979
force-pushed
the
jben94-Fix-Pag-ReccurDowntime
branch
from
1d2fe75 to
acf90b6
Compare
|
Validation ok for the 2.8.x it can now be merged. |
sc979
force-pushed
the
jben94-Fix-Pag-ReccurDowntime
branch
from
acf90b6 to
1aef0bd
Compare
Resolve MON-3518 on 2.8.x
As I couldn't push a coding style commit, on jben94's branch.
I opened a new branch to add the required commit.
From jben94 PR ->
Link issue : #6501
Link to the first PR : #6504 closed / rebased on the master
Link to the second PR PR : #6506