Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Fix pagination downtime #6506

Closed
wants to merge 3 commits into from
Closed

Fix pagination downtime #6506

wants to merge 3 commits into from

Conversation

jben94
Copy link

@jben94 jben94 commented Jul 31, 2018

Hi,

Here my change for fix pagination downtime page.
Link issue : #6501
Link old PR : https://github.com/centreon/centreon/pull/6504

Regards

@sc979
Copy link
Contributor

sc979 commented Jul 31, 2018

Thanks jben94 for your new PR.
I'll check it, tomorrow, at the office.

sc979
sc979 approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@sc979 sc979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a 2.8.24. This PR fix the issue

@sc979 sc979 mentioned this pull request Aug 1, 2018
Merged
@sc979
Copy link
Contributor

sc979 commented Aug 1, 2018

As I can't push, coding style modifications on your forked branch; I cherry-picked your commit and opened a new PR.
here : #6509

But don't be afraid, you are still the author as you can read it in the commit :
"borreljb authored and sc979 committed"

Regards,

sc

@lpinsivy
Copy link
Contributor

lpinsivy commented Aug 1, 2018

Close. Another PR with correct coding style is open.

@lpinsivy lpinsivy closed this Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sc979 sc979 sc979 approved these changes

Assignees
No one assigned
Labels
area/monitoring kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jben94 @sc979 @lpinsivy