This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Cp7 m61 fix search parameters pagination #6348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove old smarty lib and add new one to composer requirements. Update smarty plugin folder to be outside composer module. Resolves #CP7M-9
…er-lib Cp7 m9 install smarty as composer lib
replace deprecated Archive_Zip with ZipArchive class from PHP ZIP module and add composer dependency for Archive_Tar Resolves #CP7M-13
replace pear package Archive_Tar with PharData class Resolves #CP7M-13
…poser CP7M2 migrate quickform to composer
fix non numeric additions part of: cp7m10
Fixing various errors (not only smarty related) in validated views Resolves CP7M-10
* fix(base): fix some warnings and deprecations notes fix double start a session some PHP files, fix using of undefinded variables, fix calling of non-static method as static, fix using of old PEAR DB const DB_FETCHMODE_ASSOC, remove manual loading of Smarty lib from custom views section fix advmultiselect warnings and deprecates notes because the library is officially deprecated fix admin ACL UI -> fix calling of undefined index and calling of non-static method as static Resolves CP7M-15
replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index Resolves CP7M-51
* fix(global): PHP 7 compatability, deprecated function, PHP notices replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index fix PHP notices related to undefined index and fix CentreonObject::add compatibility with child objects set NULL in lower case Resolves CP7M-51
* fix(global): clean up several PHP warnings fix missing variable in pagination view, upgradeForm and service host list fix requirement of password when auth with token set TRUE in lower case Resolves CP7M-54
* refactor(quickFormCustom): change error type of applyfilter Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickform): update quickform custom stop execution if element not found
Fix pagination / search parameters get/post on administration performance data
Fix pagination / search parameters get/post on administration performance data
sc979
previously requested changes
Jun 6, 2018
| $searchH = $inputs["searchH"]; | ||
| if (isset($oreon->historySearch[$url]) && $oreon->historySearch[$url] != $searchH) { | ||
| $num = 0; | ||
| $oreon->historySearch[$url] = $searchH; |
There was a problem hiding this comment.
it was reworked, i explained in detail on chat
| } else { | ||
| $searchH = null; | ||
| } | ||
|
|
||
| if (isset($inputs["searchS"])) { | ||
| $searchS = $inputs["searchS"]; | ||
| if (isset($oreon->historySearchService[$url]) && $oreon->historySearchService[$url] != $searchS) { |
sc979
reviewed
Jun 6, 2018
sc979
approved these changes
Jun 6, 2018
v-radev
approved these changes
Jun 6, 2018
kduret
reviewed
Jun 6, 2018
| @@ -46,6 +46,8 @@ | |||
|
|
|||
| try { | |||
|
|
|||
| require_once _CENTREON_PATH_ . "vendor/smarty/smarty/libs/Smarty.class.php"; | |||
There was a problem hiding this comment.
Is it required to fix pagination ?
There was a problem hiding this comment.
no I guess it went over from the merge, I guess after including bootstrap it is not needed, so i will remove it
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* chore(build): use public repository to test * fix(db): Some PHP warnings in strict mode * fix(auth): Declaration of method not compatible with parent * fix(session): Call non-static method * Add quickform package to composer * fix docblocks * fix namespace of Exception class * fix call to undeclared function \Exception() * refactor(base): move smarty to composer managed module remove old smarty lib and add new one to composer requirements. Update smarty plugin folder to be outside composer module. Resolves #CP7M-9 * refactor(base): add changed files not inserted in previous commit Adds to: 546b316 * refactor(global): delete quickform library files * refactor(global): remove local quickform loading * refactor(global): fix quickform loading on Monitoring and Configuration * refactor(global): fix quickform loading on Administration * refactor(base): replace deprecated Archive_Zip class replace deprecated Archive_Zip with ZipArchive class from PHP ZIP module and add composer dependency for Archive_Tar Resolves #CP7M-13 * refactor(base): cleanup the code * refactor(base): replace Archive_Tar with PharData replace pear package Archive_Tar with PharData class Resolves #CP7M-13 * refactor(global): return previous quickform class * refactor(global): extend quickform from composer * refactor(base): update php warnings fix non numeric additions part of: cp7m10 * refactor(global): cleanum cutom quickform class * refactor(core): validate views post smarty update Fixing various errors (not only smarty related) in validated views Resolves CP7M-10 * Cp7 m15 fix php warnings (#6270) * fix(base): fix some warnings and deprecations notes fix double start a session some PHP files, fix using of undefinded variables, fix calling of non-static method as static, fix using of old PEAR DB const DB_FETCHMODE_ASSOC, remove manual loading of Smarty lib from custom views section fix advmultiselect warnings and deprecates notes because the library is officially deprecated fix admin ACL UI -> fix calling of undefined index and calling of non-static method as static Resolves CP7M-15 * refactor(base): Changes to PR 6271 Update db call, fix post-merge missing db execution call on images Resolves: CP7M10 * refactor(base): More Changes to PR 6271 Update free to closeCursor * refactor(global): use custom quickform class (#6273) * Cp7 m7 fix code errors and warnings (#6275) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * fix(global): load radio buttons default value (#6280) * Cp7 m24 migrate the installer and update (#6281) * refactor(install): fix upgrade process change MySQL library of php requirements and add a check for release notes file Resolves CP7M-24 * refactor(install): add missing folder and cfg mock add missing folder `www/install/tmp` and add mock of `www/install/install.conf.php` Resolves CP7M-24 * refactor(install): Fix smarty and smarty-plugins loading Resolves problem for unknown smarty plugin. Loads composer-managed smarty. * Cp7 m7 fix code errors and warnings (#6282) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(global): use quickform and smarty from composer * fix(global): PHP warnings, notifications and mergeWithInitialValues to return correct result fix CentreonUtils::mergeWithInitialValues to return result from submitted data fix PHP warinings and notifications from Host template UI fix CentreonHosttemplates::getObjectForSelect2 attributes to be the same as the parent method Resolves CP7M-7 * refactor(base) Fix errors found after running acceptance tests Fix various problems caused by Smarty and Quickform, detected by acceptance tests. Regarding CP7M7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * refactor(base): add dependency of pear-core and require newer version of PHP (#6284) add dependency of pear-core-minimal package and requrie at least version 7 of PHP Resolves CP7M-14 * Cp7 m27 widgets related fixes (#6293) * fix(global): add checks to db functions and counts * fix(global): fix PHP`s notifications and warnings * fix(services): add monitoring fixes for warnings * fix(global): Undefined variable: upgrade_infosTxt in upgrade form was missing variable Resolves CP7M-27 * fix(quickform): fix select2 default data * refactor(quickformCustom): Change error type of addRule (#6301) Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickFormCustom): change error type of applyfilter (#6302) Change fatal error to notice to comply with previous version error type all over the code. * fix(global): deprecated function, PHP notices (#6312) replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index Resolves CP7M-51 * fix(quickform): add previously deleted elements (#6311) * Cp7 m510 centreon awie (fixes) (#6313) * fix(global): PHP 7 compatability, deprecated function, PHP notices replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index fix PHP notices related to undefined index and fix CentreonObject::add compatibility with child objects set NULL in lower case Resolves CP7M-51 * fix(global): clean up several PHP warnings (#6314) * fix(global): clean up several PHP warnings fix missing variable in pagination view, upgradeForm and service host list fix requirement of password when auth with token set TRUE in lower case Resolves CP7M-54 * Change quickform custom addrule returns (#6332) * refactor(quickFormCustom): change error type of applyfilter Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickform): update quickform custom stop execution if element not found * chore(build): update Jenkinsfile. * fix(build): use /usr/bin/env in shebang instead of direct php path. * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * remove required that got carried over from the merge
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* chore(build): use public repository to test * fix(db): Some PHP warnings in strict mode * fix(auth): Declaration of method not compatible with parent * fix(session): Call non-static method * Add quickform package to composer * fix docblocks * fix namespace of Exception class * fix call to undeclared function \Exception() * refactor(base): move smarty to composer managed module remove old smarty lib and add new one to composer requirements. Update smarty plugin folder to be outside composer module. Resolves #CP7M-9 * refactor(base): add changed files not inserted in previous commit Adds to: 546b316 * refactor(global): delete quickform library files * refactor(global): remove local quickform loading * refactor(global): fix quickform loading on Monitoring and Configuration * refactor(global): fix quickform loading on Administration * refactor(base): replace deprecated Archive_Zip class replace deprecated Archive_Zip with ZipArchive class from PHP ZIP module and add composer dependency for Archive_Tar Resolves #CP7M-13 * refactor(base): cleanup the code * refactor(base): replace Archive_Tar with PharData replace pear package Archive_Tar with PharData class Resolves #CP7M-13 * refactor(global): return previous quickform class * refactor(global): extend quickform from composer * refactor(base): update php warnings fix non numeric additions part of: cp7m10 * refactor(global): cleanum cutom quickform class * refactor(core): validate views post smarty update Fixing various errors (not only smarty related) in validated views Resolves CP7M-10 * Cp7 m15 fix php warnings (#6270) * fix(base): fix some warnings and deprecations notes fix double start a session some PHP files, fix using of undefinded variables, fix calling of non-static method as static, fix using of old PEAR DB const DB_FETCHMODE_ASSOC, remove manual loading of Smarty lib from custom views section fix advmultiselect warnings and deprecates notes because the library is officially deprecated fix admin ACL UI -> fix calling of undefined index and calling of non-static method as static Resolves CP7M-15 * refactor(base): Changes to PR 6271 Update db call, fix post-merge missing db execution call on images Resolves: CP7M10 * refactor(base): More Changes to PR 6271 Update free to closeCursor * refactor(global): use custom quickform class (#6273) * Cp7 m7 fix code errors and warnings (#6275) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * fix(global): load radio buttons default value (#6280) * Cp7 m24 migrate the installer and update (#6281) * refactor(install): fix upgrade process change MySQL library of php requirements and add a check for release notes file Resolves CP7M-24 * refactor(install): add missing folder and cfg mock add missing folder `www/install/tmp` and add mock of `www/install/install.conf.php` Resolves CP7M-24 * refactor(install): Fix smarty and smarty-plugins loading Resolves problem for unknown smarty plugin. Loads composer-managed smarty. * Cp7 m7 fix code errors and warnings (#6282) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(global): use quickform and smarty from composer * fix(global): PHP warnings, notifications and mergeWithInitialValues to return correct result fix CentreonUtils::mergeWithInitialValues to return result from submitted data fix PHP warinings and notifications from Host template UI fix CentreonHosttemplates::getObjectForSelect2 attributes to be the same as the parent method Resolves CP7M-7 * refactor(base) Fix errors found after running acceptance tests Fix various problems caused by Smarty and Quickform, detected by acceptance tests. Regarding CP7M7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * refactor(base): add dependency of pear-core and require newer version of PHP (#6284) add dependency of pear-core-minimal package and requrie at least version 7 of PHP Resolves CP7M-14 * Cp7 m27 widgets related fixes (#6293) * fix(global): add checks to db functions and counts * fix(global): fix PHP`s notifications and warnings * fix(services): add monitoring fixes for warnings * fix(global): Undefined variable: upgrade_infosTxt in upgrade form was missing variable Resolves CP7M-27 * fix(quickform): fix select2 default data * refactor(quickformCustom): Change error type of addRule (#6301) Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickFormCustom): change error type of applyfilter (#6302) Change fatal error to notice to comply with previous version error type all over the code. * fix(global): deprecated function, PHP notices (#6312) replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index Resolves CP7M-51 * fix(quickform): add previously deleted elements (#6311) * Cp7 m510 centreon awie (fixes) (#6313) * fix(global): PHP 7 compatability, deprecated function, PHP notices replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index fix PHP notices related to undefined index and fix CentreonObject::add compatibility with child objects set NULL in lower case Resolves CP7M-51 * fix(global): clean up several PHP warnings (#6314) * fix(global): clean up several PHP warnings fix missing variable in pagination view, upgradeForm and service host list fix requirement of password when auth with token set TRUE in lower case Resolves CP7M-54 * Change quickform custom addrule returns (#6332) * refactor(quickFormCustom): change error type of applyfilter Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickform): update quickform custom stop execution if element not found * chore(build): update Jenkinsfile. * fix(build): use /usr/bin/env in shebang instead of direct php path. * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * remove required that got carried over from the merge
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* chore(build): use public repository to test * fix(db): Some PHP warnings in strict mode * fix(auth): Declaration of method not compatible with parent * fix(session): Call non-static method * Add quickform package to composer * fix docblocks * fix namespace of Exception class * fix call to undeclared function \Exception() * refactor(base): move smarty to composer managed module remove old smarty lib and add new one to composer requirements. Update smarty plugin folder to be outside composer module. Resolves #CP7M-9 * refactor(base): add changed files not inserted in previous commit Adds to: 546b316 * refactor(global): delete quickform library files * refactor(global): remove local quickform loading * refactor(global): fix quickform loading on Monitoring and Configuration * refactor(global): fix quickform loading on Administration * refactor(base): replace deprecated Archive_Zip class replace deprecated Archive_Zip with ZipArchive class from PHP ZIP module and add composer dependency for Archive_Tar Resolves #CP7M-13 * refactor(base): cleanup the code * refactor(base): replace Archive_Tar with PharData replace pear package Archive_Tar with PharData class Resolves #CP7M-13 * refactor(global): return previous quickform class * refactor(global): extend quickform from composer * refactor(base): update php warnings fix non numeric additions part of: cp7m10 * refactor(global): cleanum cutom quickform class * refactor(core): validate views post smarty update Fixing various errors (not only smarty related) in validated views Resolves CP7M-10 * Cp7 m15 fix php warnings (#6270) * fix(base): fix some warnings and deprecations notes fix double start a session some PHP files, fix using of undefinded variables, fix calling of non-static method as static, fix using of old PEAR DB const DB_FETCHMODE_ASSOC, remove manual loading of Smarty lib from custom views section fix advmultiselect warnings and deprecates notes because the library is officially deprecated fix admin ACL UI -> fix calling of undefined index and calling of non-static method as static Resolves CP7M-15 * refactor(base): Changes to PR 6271 Update db call, fix post-merge missing db execution call on images Resolves: CP7M10 * refactor(base): More Changes to PR 6271 Update free to closeCursor * refactor(global): use custom quickform class (#6273) * Cp7 m7 fix code errors and warnings (#6275) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * fix(global): load radio buttons default value (#6280) * Cp7 m24 migrate the installer and update (#6281) * refactor(install): fix upgrade process change MySQL library of php requirements and add a check for release notes file Resolves CP7M-24 * refactor(install): add missing folder and cfg mock add missing folder `www/install/tmp` and add mock of `www/install/install.conf.php` Resolves CP7M-24 * refactor(install): Fix smarty and smarty-plugins loading Resolves problem for unknown smarty plugin. Loads composer-managed smarty. * Cp7 m7 fix code errors and warnings (#6282) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(global): use quickform and smarty from composer * fix(global): PHP warnings, notifications and mergeWithInitialValues to return correct result fix CentreonUtils::mergeWithInitialValues to return result from submitted data fix PHP warinings and notifications from Host template UI fix CentreonHosttemplates::getObjectForSelect2 attributes to be the same as the parent method Resolves CP7M-7 * refactor(base) Fix errors found after running acceptance tests Fix various problems caused by Smarty and Quickform, detected by acceptance tests. Regarding CP7M7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * refactor(base): add dependency of pear-core and require newer version of PHP (#6284) add dependency of pear-core-minimal package and requrie at least version 7 of PHP Resolves CP7M-14 * Cp7 m27 widgets related fixes (#6293) * fix(global): add checks to db functions and counts * fix(global): fix PHP`s notifications and warnings * fix(services): add monitoring fixes for warnings * fix(global): Undefined variable: upgrade_infosTxt in upgrade form was missing variable Resolves CP7M-27 * fix(quickform): fix select2 default data * refactor(quickformCustom): Change error type of addRule (#6301) Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickFormCustom): change error type of applyfilter (#6302) Change fatal error to notice to comply with previous version error type all over the code. * fix(global): deprecated function, PHP notices (#6312) replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index Resolves CP7M-51 * fix(quickform): add previously deleted elements (#6311) * Cp7 m510 centreon awie (fixes) (#6313) * fix(global): PHP 7 compatability, deprecated function, PHP notices replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index fix PHP notices related to undefined index and fix CentreonObject::add compatibility with child objects set NULL in lower case Resolves CP7M-51 * fix(global): clean up several PHP warnings (#6314) * fix(global): clean up several PHP warnings fix missing variable in pagination view, upgradeForm and service host list fix requirement of password when auth with token set TRUE in lower case Resolves CP7M-54 * Change quickform custom addrule returns (#6332) * refactor(quickFormCustom): change error type of applyfilter Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickform): update quickform custom stop execution if element not found * chore(build): update Jenkinsfile. * fix(build): use /usr/bin/env in shebang instead of direct php path. * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * remove required that got carried over from the merge
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* chore(build): use public repository to test * fix(db): Some PHP warnings in strict mode * fix(auth): Declaration of method not compatible with parent * fix(session): Call non-static method * Add quickform package to composer * fix docblocks * fix namespace of Exception class * fix call to undeclared function \Exception() * refactor(base): move smarty to composer managed module remove old smarty lib and add new one to composer requirements. Update smarty plugin folder to be outside composer module. Resolves #CP7M-9 * refactor(base): add changed files not inserted in previous commit Adds to: 546b316 * refactor(global): delete quickform library files * refactor(global): remove local quickform loading * refactor(global): fix quickform loading on Monitoring and Configuration * refactor(global): fix quickform loading on Administration * refactor(base): replace deprecated Archive_Zip class replace deprecated Archive_Zip with ZipArchive class from PHP ZIP module and add composer dependency for Archive_Tar Resolves #CP7M-13 * refactor(base): cleanup the code * refactor(base): replace Archive_Tar with PharData replace pear package Archive_Tar with PharData class Resolves #CP7M-13 * refactor(global): return previous quickform class * refactor(global): extend quickform from composer * refactor(base): update php warnings fix non numeric additions part of: cp7m10 * refactor(global): cleanum cutom quickform class * refactor(core): validate views post smarty update Fixing various errors (not only smarty related) in validated views Resolves CP7M-10 * Cp7 m15 fix php warnings (#6270) * fix(base): fix some warnings and deprecations notes fix double start a session some PHP files, fix using of undefinded variables, fix calling of non-static method as static, fix using of old PEAR DB const DB_FETCHMODE_ASSOC, remove manual loading of Smarty lib from custom views section fix advmultiselect warnings and deprecates notes because the library is officially deprecated fix admin ACL UI -> fix calling of undefined index and calling of non-static method as static Resolves CP7M-15 * refactor(base): Changes to PR 6271 Update db call, fix post-merge missing db execution call on images Resolves: CP7M10 * refactor(base): More Changes to PR 6271 Update free to closeCursor * refactor(global): use custom quickform class (#6273) * Cp7 m7 fix code errors and warnings (#6275) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * fix(global): load radio buttons default value (#6280) * Cp7 m24 migrate the installer and update (#6281) * refactor(install): fix upgrade process change MySQL library of php requirements and add a check for release notes file Resolves CP7M-24 * refactor(install): add missing folder and cfg mock add missing folder `www/install/tmp` and add mock of `www/install/install.conf.php` Resolves CP7M-24 * refactor(install): Fix smarty and smarty-plugins loading Resolves problem for unknown smarty plugin. Loads composer-managed smarty. * Cp7 m7 fix code errors and warnings (#6282) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(global): use quickform and smarty from composer * fix(global): PHP warnings, notifications and mergeWithInitialValues to return correct result fix CentreonUtils::mergeWithInitialValues to return result from submitted data fix PHP warinings and notifications from Host template UI fix CentreonHosttemplates::getObjectForSelect2 attributes to be the same as the parent method Resolves CP7M-7 * refactor(base) Fix errors found after running acceptance tests Fix various problems caused by Smarty and Quickform, detected by acceptance tests. Regarding CP7M7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * refactor(base): add dependency of pear-core and require newer version of PHP (#6284) add dependency of pear-core-minimal package and requrie at least version 7 of PHP Resolves CP7M-14 * Cp7 m27 widgets related fixes (#6293) * fix(global): add checks to db functions and counts * fix(global): fix PHP`s notifications and warnings * fix(services): add monitoring fixes for warnings * fix(global): Undefined variable: upgrade_infosTxt in upgrade form was missing variable Resolves CP7M-27 * fix(quickform): fix select2 default data * refactor(quickformCustom): Change error type of addRule (#6301) Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickFormCustom): change error type of applyfilter (#6302) Change fatal error to notice to comply with previous version error type all over the code. * fix(global): deprecated function, PHP notices (#6312) replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index Resolves CP7M-51 * fix(quickform): add previously deleted elements (#6311) * Cp7 m510 centreon awie (fixes) (#6313) * fix(global): PHP 7 compatability, deprecated function, PHP notices replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index fix PHP notices related to undefined index and fix CentreonObject::add compatibility with child objects set NULL in lower case Resolves CP7M-51 * fix(global): clean up several PHP warnings (#6314) * fix(global): clean up several PHP warnings fix missing variable in pagination view, upgradeForm and service host list fix requirement of password when auth with token set TRUE in lower case Resolves CP7M-54 * Change quickform custom addrule returns (#6332) * refactor(quickFormCustom): change error type of applyfilter Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickform): update quickform custom stop execution if element not found * chore(build): update Jenkinsfile. * fix(build): use /usr/bin/env in shebang instead of direct php path. * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * remove required that got carried over from the merge
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* chore(build): use public repository to test * fix(db): Some PHP warnings in strict mode * fix(auth): Declaration of method not compatible with parent * fix(session): Call non-static method * Add quickform package to composer * fix docblocks * fix namespace of Exception class * fix call to undeclared function \Exception() * refactor(base): move smarty to composer managed module remove old smarty lib and add new one to composer requirements. Update smarty plugin folder to be outside composer module. Resolves #CP7M-9 * refactor(base): add changed files not inserted in previous commit Adds to: 546b316 * refactor(global): delete quickform library files * refactor(global): remove local quickform loading * refactor(global): fix quickform loading on Monitoring and Configuration * refactor(global): fix quickform loading on Administration * refactor(base): replace deprecated Archive_Zip class replace deprecated Archive_Zip with ZipArchive class from PHP ZIP module and add composer dependency for Archive_Tar Resolves #CP7M-13 * refactor(base): cleanup the code * refactor(base): replace Archive_Tar with PharData replace pear package Archive_Tar with PharData class Resolves #CP7M-13 * refactor(global): return previous quickform class * refactor(global): extend quickform from composer * refactor(base): update php warnings fix non numeric additions part of: cp7m10 * refactor(global): cleanum cutom quickform class * refactor(core): validate views post smarty update Fixing various errors (not only smarty related) in validated views Resolves CP7M-10 * Cp7 m15 fix php warnings (#6270) * fix(base): fix some warnings and deprecations notes fix double start a session some PHP files, fix using of undefinded variables, fix calling of non-static method as static, fix using of old PEAR DB const DB_FETCHMODE_ASSOC, remove manual loading of Smarty lib from custom views section fix advmultiselect warnings and deprecates notes because the library is officially deprecated fix admin ACL UI -> fix calling of undefined index and calling of non-static method as static Resolves CP7M-15 * refactor(base): Changes to PR 6271 Update db call, fix post-merge missing db execution call on images Resolves: CP7M10 * refactor(base): More Changes to PR 6271 Update free to closeCursor * refactor(global): use custom quickform class (#6273) * Cp7 m7 fix code errors and warnings (#6275) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * fix(global): load radio buttons default value (#6280) * Cp7 m24 migrate the installer and update (#6281) * refactor(install): fix upgrade process change MySQL library of php requirements and add a check for release notes file Resolves CP7M-24 * refactor(install): add missing folder and cfg mock add missing folder `www/install/tmp` and add mock of `www/install/install.conf.php` Resolves CP7M-24 * refactor(install): Fix smarty and smarty-plugins loading Resolves problem for unknown smarty plugin. Loads composer-managed smarty. * Cp7 m7 fix code errors and warnings (#6282) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(global): use quickform and smarty from composer * fix(global): PHP warnings, notifications and mergeWithInitialValues to return correct result fix CentreonUtils::mergeWithInitialValues to return result from submitted data fix PHP warinings and notifications from Host template UI fix CentreonHosttemplates::getObjectForSelect2 attributes to be the same as the parent method Resolves CP7M-7 * refactor(base) Fix errors found after running acceptance tests Fix various problems caused by Smarty and Quickform, detected by acceptance tests. Regarding CP7M7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * refactor(base): add dependency of pear-core and require newer version of PHP (#6284) add dependency of pear-core-minimal package and requrie at least version 7 of PHP Resolves CP7M-14 * Cp7 m27 widgets related fixes (#6293) * fix(global): add checks to db functions and counts * fix(global): fix PHP`s notifications and warnings * fix(services): add monitoring fixes for warnings * fix(global): Undefined variable: upgrade_infosTxt in upgrade form was missing variable Resolves CP7M-27 * fix(quickform): fix select2 default data * refactor(quickformCustom): Change error type of addRule (#6301) Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickFormCustom): change error type of applyfilter (#6302) Change fatal error to notice to comply with previous version error type all over the code. * fix(global): deprecated function, PHP notices (#6312) replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index Resolves CP7M-51 * fix(quickform): add previously deleted elements (#6311) * Cp7 m510 centreon awie (fixes) (#6313) * fix(global): PHP 7 compatability, deprecated function, PHP notices replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index fix PHP notices related to undefined index and fix CentreonObject::add compatibility with child objects set NULL in lower case Resolves CP7M-51 * fix(global): clean up several PHP warnings (#6314) * fix(global): clean up several PHP warnings fix missing variable in pagination view, upgradeForm and service host list fix requirement of password when auth with token set TRUE in lower case Resolves CP7M-54 * Change quickform custom addrule returns (#6332) * refactor(quickFormCustom): change error type of applyfilter Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickform): update quickform custom stop execution if element not found * chore(build): update Jenkinsfile. * fix(build): use /usr/bin/env in shebang instead of direct php path. * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * remove required that got carried over from the merge
kduret
pushed a commit
that referenced
this pull request
Jun 20, 2018
* chore(build): use public repository to test * fix(db): Some PHP warnings in strict mode * fix(auth): Declaration of method not compatible with parent * fix(session): Call non-static method * Add quickform package to composer * fix docblocks * fix namespace of Exception class * fix call to undeclared function \Exception() * refactor(base): move smarty to composer managed module remove old smarty lib and add new one to composer requirements. Update smarty plugin folder to be outside composer module. Resolves #CP7M-9 * refactor(base): add changed files not inserted in previous commit Adds to: 546b316 * refactor(global): delete quickform library files * refactor(global): remove local quickform loading * refactor(global): fix quickform loading on Monitoring and Configuration * refactor(global): fix quickform loading on Administration * refactor(base): replace deprecated Archive_Zip class replace deprecated Archive_Zip with ZipArchive class from PHP ZIP module and add composer dependency for Archive_Tar Resolves #CP7M-13 * refactor(base): cleanup the code * refactor(base): replace Archive_Tar with PharData replace pear package Archive_Tar with PharData class Resolves #CP7M-13 * refactor(global): return previous quickform class * refactor(global): extend quickform from composer * refactor(base): update php warnings fix non numeric additions part of: cp7m10 * refactor(global): cleanum cutom quickform class * refactor(core): validate views post smarty update Fixing various errors (not only smarty related) in validated views Resolves CP7M-10 * Cp7 m15 fix php warnings (#6270) * fix(base): fix some warnings and deprecations notes fix double start a session some PHP files, fix using of undefinded variables, fix calling of non-static method as static, fix using of old PEAR DB const DB_FETCHMODE_ASSOC, remove manual loading of Smarty lib from custom views section fix advmultiselect warnings and deprecates notes because the library is officially deprecated fix admin ACL UI -> fix calling of undefined index and calling of non-static method as static Resolves CP7M-15 * refactor(base): Changes to PR 6271 Update db call, fix post-merge missing db execution call on images Resolves: CP7M10 * refactor(base): More Changes to PR 6271 Update free to closeCursor * refactor(global): use custom quickform class (#6273) * Cp7 m7 fix code errors and warnings (#6275) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * fix(global): load radio buttons default value (#6280) * Cp7 m24 migrate the installer and update (#6281) * refactor(install): fix upgrade process change MySQL library of php requirements and add a check for release notes file Resolves CP7M-24 * refactor(install): add missing folder and cfg mock add missing folder `www/install/tmp` and add mock of `www/install/install.conf.php` Resolves CP7M-24 * refactor(install): Fix smarty and smarty-plugins loading Resolves problem for unknown smarty plugin. Loads composer-managed smarty. * Cp7 m7 fix code errors and warnings (#6282) * fix(global): remove warnings and undefined variables * refactor(core): rework post-upgrade errors Refactor code not compliant with php7.2 Regarding: CP7M-7 * fix(global): remove small warnings and errors * refactor(core): call non-static method in widgets as host-monitoring calls methods CentreonUtils::conditionBuilder and CentreonUtils::operandToMysqlFormat as static but they are non-static Resolves CP7M-7 * fix(global): remove small warnings and errors * refactor(core): fix warnings from tests fix issues as "Only variables should be assigned by reference", "Undefined index", "Methods with the same name as their class will not be constructors in a future version of PHP" and etc. Resolves CP7M-7 * fix(global): use quickform and smarty from composer * fix(global): PHP warnings, notifications and mergeWithInitialValues to return correct result fix CentreonUtils::mergeWithInitialValues to return result from submitted data fix PHP warinings and notifications from Host template UI fix CentreonHosttemplates::getObjectForSelect2 attributes to be the same as the parent method Resolves CP7M-7 * refactor(base) Fix errors found after running acceptance tests Fix various problems caused by Smarty and Quickform, detected by acceptance tests. Regarding CP7M7 * fix(config): fix variable name (#6276) Fix incorrectly pushed variable name * refactor(base): add dependency of pear-core and require newer version of PHP (#6284) add dependency of pear-core-minimal package and requrie at least version 7 of PHP Resolves CP7M-14 * Cp7 m27 widgets related fixes (#6293) * fix(global): add checks to db functions and counts * fix(global): fix PHP`s notifications and warnings * fix(services): add monitoring fixes for warnings * fix(global): Undefined variable: upgrade_infosTxt in upgrade form was missing variable Resolves CP7M-27 * fix(quickform): fix select2 default data * refactor(quickformCustom): Change error type of addRule (#6301) Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickFormCustom): change error type of applyfilter (#6302) Change fatal error to notice to comply with previous version error type all over the code. * fix(global): deprecated function, PHP notices (#6312) replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index Resolves CP7M-51 * fix(quickform): add previously deleted elements (#6311) * Cp7 m510 centreon awie (fixes) (#6313) * fix(global): PHP 7 compatability, deprecated function, PHP notices replace using of deprecated each() function with foreach(), fix several PHP notices related with undefined index fix PHP notices related to undefined index and fix CentreonObject::add compatibility with child objects set NULL in lower case Resolves CP7M-51 * fix(global): clean up several PHP warnings (#6314) * fix(global): clean up several PHP warnings fix missing variable in pagination view, upgradeForm and service host list fix requirement of password when auth with token set TRUE in lower case Resolves CP7M-54 * Change quickform custom addrule returns (#6332) * refactor(quickFormCustom): change error type of applyfilter Change fatal error to notice to comply with previous version error type all over the code. * refactor(quickform): update quickform custom stop execution if element not found * chore(build): update Jenkinsfile. * fix(build): use /usr/bin/env in shebang instead of direct php path. * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * fix(pagination,search): CP7M61 performance data Fix pagination / search parameters get/post on administration performance data * remove required that got carried over from the merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.