Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

CP7M2 migrate quickform to composer #6267

Merged
merged 5 commits into from
May 4, 2018

Conversation

v-radev
Copy link
Contributor

@v-radev v-radev commented May 3, 2018

Remove all local QuickForm files and replace all usages with a composer package. Manually load custom select2 and advmultiselect fields.

@@ -133,8 +133,8 @@
$form->registerRule('is_writable_file_if_exist', 'callback', 'is_writable_file_if_exist');
$form->registerRule('isNum', 'callback', 'isNum');

$form->addRule('nagios_path_img', _("The directory isn't valid"), 'is_valid_path_images');
$form->addRule('nagios_path', _("The directory isn't valid"), 'is_valid_path');
// $form->addRule('nagios_path_img', _("The directory isn't valid"), 'is_valid_path_images'); - Field is not added so no need for rule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see dead code, delete it instead of comment it

@v-radev v-radev merged commit 8b4e36c into php7-migration May 4, 2018
@v-radev v-radev deleted the CP7M2-migrate-quickform-to-composer branch May 4, 2018 06:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants