This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kduret
suggested changes
Oct 18, 2017
* @param $sg_name | ||
* @return int|mixed | ||
*/ | ||
public function getServicesGroupId($sg_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use lower camelcase
kduret
approved these changes
Oct 19, 2017
Guillaume28
approved these changes
Oct 20, 2017
loiclau
force-pushed
the
api-rt-exception-master
branch
2 times, most recently
from
October 30, 2017 12:38
93c713c
to
7018544
Compare
kduret
force-pushed
the
api-rt-exception-master
branch
from
November 2, 2017 14:36
7018544
to
695a8db
Compare
-change host/service separator of | to , -add to add/show multi object downtime with | separator -update doc and acceptance -change order/declaration of service inheritance on add method
loiclau
force-pushed
the
api-rt-exception-master
branch
from
November 3, 2017 13:59
695a8db
to
3cfe299
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5735
-add check on rt downtime
-check invalid date
-change host/service separator of | to ,
-add to add/show multi object downtime with | separator
-update doc and acceptance
-change order/declaration of service inheritance on add method