This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Api rt exception 2.8 #5735
Merged
Api rt exception 2.8 #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiclau
force-pushed
the
api-rt-exception-2.8
branch
from
da1074e to
bb4f162
Compare
kduret
approved these changes
Oct 9, 2017
loiclau
force-pushed
the
api-rt-exception-2.8
branch
from
bb4f162 to
9950f93
Compare
kduret
approved these changes
Oct 17, 2017
kduret
suggested changes
Oct 17, 2017
| * @param $sg_name | ||
| * @return int|mixed | ||
| */ | ||
| public function getServicesGroupId($sg_name) |
Guillaume28
approved these changes
Oct 31, 2017
kduret
approved these changes
Nov 2, 2017
|
Everything looks good to me. Exeptions are correctly handled for the most common user cases. OK |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5796
-add check on rt downtime
-check invalid date
-change host/service separator of | to ,
-add to add/show multi object downtime with | separator
-update doc and acceptance
-change order/declaration of service inheritance on add method