Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing multiple worker applications (issue #816). #817

Closed
wants to merge 5 commits into from
Closed

Allowing multiple worker applications (issue #816). #817

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11f7dfd
This will allow applications with multiple workers such as uvicorn an…
renan-alonkin Nov 14, 2019
629a500
Changed exists_ok to path.exists, making it compatible with python 2.x
renan-alonkin Nov 14, 2019
531dd68
substitute to mkdir's exist_ok=True
renan-alonkin Nov 14, 2019
9757f69
substitute to mkdir's exist_ok=True
renan-alonkin Nov 14, 2019
a7fa288
substitute to mkdir's exist_ok=True
renan-alonkin Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion contrib/opencensus-ext-azure/opencensus/ext/azure/common/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@

from opencensus.common.schedule import PeriodicTask

try:
from pathlib import Path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to import Path? I don't see it being used in the logic?

except ImportError:
from pathlib2 import Path # python 2 backport


def _fmt(timestamp):
return timestamp.strftime('%Y-%m-%dT%H%M%S.%f')
Expand Down Expand Up @@ -109,7 +114,7 @@ def __exit__(self, type, value, traceback):
def _maintenance_routine(self, silent=False):
try:
if not os.path.isdir(self.path):
os.makedirs(self.path)
os.makedirs(self.path, exist_ok=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a comment explaining the reasoning for this? (raise condition when os.makedirs is called after the if check passes but the file was already created by another worker).

except Exception:
if not silent:
raise
Expand Down