Allowing multiple worker applications (issue #816). #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renan-alonkin
requested review from
c24t,
reyang,
songy23 and
a team
as code owners
lzchen
reviewed
Nov 15, 2019
| @@ -109,7 +114,7 @@ def __exit__(self, type, value, traceback): | |||
| def _maintenance_routine(self, silent=False): | |||
| try: | |||
| if not os.path.isdir(self.path): | |||
| os.makedirs(self.path) | |||
| os.makedirs(self.path, exist_ok=True) | |||
There was a problem hiding this comment.
Can you put a comment explaining the reasoning for this? (raise condition when os.makedirs is called after the if check passes but the file was already created by another worker).
lzchen
reviewed
Nov 15, 2019
| @@ -5,6 +5,11 @@ | |||
|
|
|||
| from opencensus.common.schedule import PeriodicTask | |||
|
|
|||
| try: | |||
| from pathlib import Path | |||
There was a problem hiding this comment.
Why do we need to import Path? I don't see it being used in the logic?
|
Address [#816] |
|
Closing due to workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
exist_ok=Truetoopencensus-ext-azure.ext.azure.common.storage._maintenance_routineto avoid raisingFileExistsErrorif the target directory already exists, which is the default behavior (exist_ok=False). This behavior (exist_ok=False) do not allow multiple worker applications (such as uvicorn) to performrun.