Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: consistent formatting of mainnet node hosts #1554

Merged
merged 1 commit into from
May 1, 2024

Conversation

ramin
Copy link
Contributor

@ramin ramin commented May 1, 2024

Overview

I noticed some inconsistency in how nodes were listed. some with a trailing slash, some with the scheme. I've unified these for the nodes/mainnet.md list

Summary by CodeRabbit

  • Documentation
    • Updated URLs for Mainnet Beta participation endpoints, including RPC, API, gRPC, and WebSocket, by removing https:// prefixes and adjusting domain names for improved accessibility and compliance.

@ramin ramin requested a review from jcstein May 1, 2024 09:06
Copy link
Contributor

coderabbitai bot commented May 1, 2024

Walkthrough

The recent modifications primarily focus on streamlining connectivity by updating the URLs for various network endpoints used in Mainnet Beta. This involves the removal of the https:// prefix and adjustments to domain names across RPC, API, gRPC, and WebSocket services.

Changes

File Path Change Summary
nodes/mainnet.md Updated URLs by removing https:// and adjusting domain names for RPC, API, gRPC, and WebSocket endpoints.

🐰✨🌟
In the digital meadow, under the byte-sized sun,
Little changes hop along, simplifying one by one.
No more 'https' to type, a cleaner path we pave,
For every node and link, making data waves.
🌼🌿🐇


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ca2e8a9 and f4b404a.
Files selected for processing (1)
  • nodes/mainnet.md (3 hunks)
Additional Context Used
LanguageTool (30)
nodes/mainnet.md (30)

Near line 3: Possible spelling mistake found.
Context: # Mainnet Beta <script setup> import MainnetVers...


Near line 12: Possible spelling mistake found.
Context: ...net-Beta.png) Welcome to the guide for Celestia’s Mainnet Beta, the production network ...


Near line 12: Possible spelling mistake found.
Context: ...g) Welcome to the guide for Celestia’s Mainnet Beta, the production network that marks...


Near line 13: Possible spelling mistake found.
Context: ...tion network that marks the pinnacle of Celestia’s evolution since its inception in 2019...


Near line 14: Possible spelling mistake found.
Context: ... network is where all components of the Celestia ecosystem come to life in a real-world ...


Near line 16: Possible spelling mistake found.
Context: ...e to life in a real-world environment. Mainnet Beta is the culmination of rigorous com...


Near line 18: Possible spelling mistake found.
Context: ...It serves as the platform for deploying mainnet rollups and applications. ## Network s...


Near line 19: Possible spelling mistake found.
Context: ...s as the platform for deploying mainnet rollups and applications. ## Network stability...


Near line 22: Possible spelling mistake found.
Context: ...ns. ## Network stability and upgrades Mainnet Beta is a stable network, but will stil...


Near line 25: Possible spelling mistake found.
Context: ...ted with node operators and the broader Celestia community to ensure seamless integratio...


Near line 29: Possible spelling mistake found.
Context: ...sampling, it's crucial to remember that Mainnet Beta remains experimental at this stage...


Near line 45: Possible spelling mistake found.
Context: ...s.md?plain=1#L30), can be found in the [celestia-app specifications](https://celestiaorg.git...


Near line 47: Unpaired symbol: ‘[’ seems to be missing
Context: ...elestia-app/specs/params.html). [CIP-13](https://github.com/celestiaorg/CIPs/blo...


Near line 79: Possible spelling mistake found.
Context: ...arameter and a hard-coded constant in CometBFT. - The number of shares occupied by the...


Near line 87: Possible spelling mistake found.
Context: ...relevant sections for how to connect to Mainnet Beta, depending on the type of node you...


Near line 90: Consider a shorter alternative to avoid wordiness.
Context: ...guide will link to the relevant network in order to show you how to connect to them. Learn ...


Near line 94: Consider a shorter alternative to avoid wordiness.
Context: ...tions of the types of nodes you can run in order to participate in Mainnet Beta: ### Conse...


Near line 95: Possible spelling mistake found.
Context: ... you can run in order to participate in Mainnet Beta: ### Consensus nodes - [Full con...


Near line 180: Possible spelling mistake found.
Context: ...estia-grpc.noders.services:11090 #### WebSocket endpoints -wss://celestia-ws.chainod...


Near line 193: Possible spelling mistake found.
Context: ...sactions (balances, blobs, etc.) to the Celestia network. For users, they will need to p...


Near line 194: Possible spelling mistake found.
Context: ... For users, they will need to provide a –core.ip string from a consensus node’s URL or ...


Near line 214: Possible spelling mistake. ‘initialise’ is British English.
Context: ... bridge node. ::: RPCs for DA nodes to initialise or start your celestia-node to Mainnet ...


Near line 214: Possible spelling mistake found.
Context: ...or DA nodes to initialise or start your celestia-node to Mainnet Beta with: - `public-celest...


Near line 214: Possible spelling mistake found.
Context: ...itialise or start your celestia-node to Mainnet Beta with: - `public-celestia-consensu...


Near line 235: Possible spelling mistake found.
Context: .../uptime status of DA bootstrappers (now celestia network only). You can [find the stat...


Near line 243: Possible missing comma found.
Context: ...istory of the chain without pruning any data so all data available data is retrievab...


Near line 248: Possible spelling mistake found.
Context: ... endpoints You can [provision your own Celestia Archival endpoint on Grove](https://gro...


Near line 249: Possible spelling mistake found.
Context: ...(https://grove.city). [Learn more about Celestia on Grove](https://docs.grove.city/celes...


Near line 258: Possible spelling mistake found.
Context: ... are multiple explorers you can use for Mainnet Beta: - [https://celenium.io](https://...


Near line 270: Possible spelling mistake found.
Context: ...ollowing websites provide analytics for Celestia: - [https://analytics.smartstake.io/ce...

Additional comments not posted (3)
nodes/mainnet.md (3)

126-127: Standardization of node URLs looks good and consistent.


151-153: Standardization of API endpoints is consistent and aligns with the PR objectives.


177-177: Standardization of gRPC endpoints is consistent and aligns with the PR objectives.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jcstein
Copy link
Member

jcstein commented May 1, 2024

FWIW this PR celestiaorg/celestia-node#2277 is why there are no http or https with endpoints for using with celestia-node in docs

@jcstein jcstein merged commit c57e0d2 into celestiaorg:main May 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants