Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodebuilder): add ip resolving capabilities to core.ip #2277

Merged
merged 3 commits into from
May 31, 2023

Conversation

sysrex
Copy link
Contributor

@sysrex sysrex commented May 30, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions github-actions bot added the external Issues created by non node team members label May 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #2277 (90371ae) into main (5d0424a) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
- Coverage   50.65%   50.57%   -0.09%     
==========================================
  Files         154      154              
  Lines        9620     9620              
==========================================
- Hits         4873     4865       -8     
- Misses       4323     4330       +7     
- Partials      424      425       +1     

see 4 files with indirect coverage changes

@sysrex sysrex added the kind:feat Attached to feature PRs label May 30, 2023
@sysrex sysrex self-assigned this May 30, 2023
@sysrex sysrex changed the title [WIP] Add ip resolving capabilities to core.ip Add ip resolving capabilities to core.ip May 30, 2023
@sysrex sysrex changed the title Add ip resolving capabilities to core.ip feat! add ip resolving capabilities to core.ip May 30, 2023
@sysrex sysrex changed the title feat! add ip resolving capabilities to core.ip feat(nodebuilder) add ip resolving capabilities to core.ip May 30, 2023
@sysrex sysrex changed the title feat(nodebuilder) add ip resolving capabilities to core.ip feat(nodebuilder): add ip resolving capabilities to core.ip May 30, 2023
@sysrex sysrex added the area:config CLI and config label May 30, 2023
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document on the command that we can now resolve DNSs and mention that the first one resolved is always used and then LGTM

@sysrex
Copy link
Contributor Author

sysrex commented May 31, 2023

Let's document on the command that we can now resolve DNSs and mention that the first one resolved is always used and then LGTM

Done and updated the PR

@Wondertan
Copy link
Member

Thank you @sysrex!

@Wondertan Wondertan enabled auto-merge (squash) May 31, 2023 08:38
@Wondertan Wondertan merged commit 011765a into celestiaorg:main May 31, 2023
Wondertan added a commit that referenced this pull request Jun 2, 2023
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config CLI and config external Issues created by non node team members kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants