chore(modstate): Remove IsStopped endpoint from StateModule #2912
Conversation
Chirag018
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
remove comments
There was a problem hiding this comment.
Hello Chirag018, thank you for your contribution. Thank you for your contribution. Unfortunately, it will break the logic of handling POST requests in the gateway. The condition if r.Method == http.MethodPost && state.IsStopped(r.Context()) disables all POST requests only if the state module was stopped when a Bad Encoding Fraud Proof is received, and the network halts.
vgonkivs
added
kind:refactor
|
@Chirag018 , could you please fix lint errors? |
yeah, will have a look on it |
|
@vgonkivs, While addressing lint issues, I identified code duplication in the state file. To resolve this, should I refactor the API.Interface struct or make other related changes? cc: @Wondertan @renaynay |
|
@Chirag018, refactoring that struct should do the thing. cc @distractedm1nd for confirmation |
|
OK, will wait for @distractedm1nd 's confirmation |
|
Yes, it needs to be removed from the API struct as well as the Module interface - don't forget to remove the implementations as well :) That should do the trick |
|
@Chirag018 do you still want to finish up this PR? Just add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
=======================================
Coverage 51.29% 51.29%
=======================================
Files 177 177
Lines 11151 11139 -12
=======================================
- Hits 5720 5714 -6
+ Misses 4935 4924 -11
- Partials 496 501 +5 ☔ View full report in Codecov by Sentry. |
|
@Chirag018 can you rebase main onto here? Or at least adjust the PR so we can update the PR with base branch, then this'll merge. Thanks! |
@Wondertan is this what you expected? Closes #2906
…org#2912) @Wondertan is this what you expected? Closes celestiaorg#2906
…org#2912) @Wondertan is this what you expected? Closes celestiaorg#2906
@Wondertan is this what you expected?
Closes #2906