Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modstate: Remove IsStopped endpoint on StateModule #2906

Closed
Wondertan opened this issue Nov 6, 2023 · 3 comments · Fixed by #2912
Closed

modstate: Remove IsStopped endpoint on StateModule #2906

Wondertan opened this issue Nov 6, 2023 · 3 comments · Fixed by #2912
Labels
area:api Related to celestia-node API

Comments

@Wondertan
Copy link
Member

We were supposed to remove it before 0.12 as part of all breaking changes removal, but it seems to be forgotten
@Wondertan Wondertan added the area:api Related to celestia-node API label Nov 6, 2023
@Chirag018
Copy link
Contributor

@Wondertan Even the methods across the repository should be removed, right?

@Wondertan
Copy link
Member Author

Yes, @Chirag018

@Wondertan
Copy link
Member Author

It's a relic

Chirag018 added a commit to Chirag018/celestia-node that referenced this issue Nov 7, 2023
@Chirag018
chore(modstate): Remove IsStopped endpoint from StateModule
9a43673 
Closes celestiaorg#2906
@Chirag018 Chirag018 mentioned this issue Nov 7, 2023
Merged
ramin pushed a commit that referenced this issue Jan 10, 2024
@Chirag018
chore(modstate): Remove IsStopped endpoint from StateModule (#2912)
49894c0 
@Wondertan is this what you expected?

Closes #2906
distractedm1nd pushed a commit that referenced this issue Jan 10, 2024
@Chirag018 @distractedm1nd
chore(modstate): Remove IsStopped endpoint from StateModule (#2912)
0dbf3f8 
@Wondertan is this what you expected?

Closes #2906
renaynay pushed a commit to renaynay/celestia-node that referenced this issue Jan 15, 2024
@Chirag018 @renaynay
chore(modstate): Remove IsStopped endpoint from StateModule (celestia…
ed1d5c4 
…org#2912)

@Wondertan is this what you expected?

Closes celestiaorg#2906
renaynay pushed a commit to renaynay/celestia-node that referenced this issue Jan 15, 2024
@Chirag018 @renaynay
chore(modstate): Remove IsStopped endpoint from StateModule (celestia…
8634125 
…org#2912)

@Wondertan is this what you expected?

Closes celestiaorg#2906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Related to celestia-node API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(modstate): Remove IsStopped endpoint from StateModule Chirag018/celestia-node
2 participants
@Wondertan @Chirag018