Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share): Ensure empty CAR exists in eds.Store #1409

Merged
merged 7 commits into from
Dec 20, 2022

Conversation

distractedm1nd
Copy link
Member

@distractedm1nd distractedm1nd commented Nov 30, 2022

Overview

Closes #1113
This PR adds an empty CAR to the eds.Store during startup of the store.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@distractedm1nd distractedm1nd added area:shares Shares and samples kind:feat Attached to feature PRs labels Nov 30, 2022
@distractedm1nd distractedm1nd self-assigned this Nov 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Merging #1409 (d1afb9c) into main (f518fc4) will decrease coverage by 0.07%.
The diff coverage is 60.60%.

@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
- Coverage   55.57%   55.50%   -0.08%     
==========================================
  Files         203      203              
  Lines       12144    12151       +7     
==========================================
- Hits         6749     6744       -5     
- Misses       4726     4734       +8     
- Partials      669      673       +4     
Impacted Files Coverage Δ
share/eds/store.go 54.21% <ø> (+2.10%) ⬆️
nodebuilder/share/module.go 72.54% <11.11%> (-4.54%) ⬇️
nodebuilder/share/constructors.go 92.10% <66.66%> (-7.90%) ⬇️
share/empty.go 86.66% <86.66%> (-13.34%) ⬇️
share/eds/byzantine/bad_encoding.go 66.00% <0.00%> (-3.00%) ⬇️
share/eds/byzantine/pb/share.pb.go 32.88% <0.00%> (-1.97%) ⬇️
nodebuilder/node/admin.go 25.00% <0.00%> (-1.67%) ⬇️
share/ipld/get.go 92.18% <0.00%> (-1.24%) ⬇️
nodebuilder/p2p/host.go 90.62% <0.00%> (-0.29%) ⬇️
share/ipld/proof.go 100.00% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@distractedm1nd distractedm1nd marked this pull request as ready for review December 7, 2022 11:49
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment.

We also should not merge this before we do v0.5.0

share/eds/store.go Outdated Show resolved Hide resolved
nodebuilder/share/module.go Outdated Show resolved Hide resolved
nodebuilder/share/module.go Show resolved Hide resolved
nodebuilder/share/constructors.go Outdated Show resolved Hide resolved
Wondertan
Wondertan previously approved these changes Dec 15, 2022
Wondertan
Wondertan previously approved these changes Dec 19, 2022
renaynay
renaynay previously approved these changes Dec 19, 2022
nodebuilder/share/constructors.go Outdated Show resolved Hide resolved
share/eds/store.go Outdated Show resolved Hide resolved
share/empty.go Show resolved Hide resolved
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
@distractedm1nd distractedm1nd merged commit 0c26695 into celestiaorg:main Dec 20, 2022
@Wondertan Wondertan deleted the empty-car branch December 20, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:feat Attached to feature PRs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

node: Ensure EDStore has EDS of an empty block
5 participants