Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Ensure EDStore has EDS of an empty block #1113

Closed
Tracked by #1099
Wondertan opened this issue Sep 15, 2022 · 0 comments · Fixed by #1409
Closed
Tracked by #1099

node: Ensure EDStore has EDS of an empty block #1113

Wondertan opened this issue Sep 15, 2022 · 0 comments · Fixed by #1409
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Sep 15, 2022 •
edited
Loading

Context

The empty block is valid and small EDS. It can happen in the early stage of the network. Its body is constant, and to avoid
transferring it over the wire, the EDSStore should be pre-initialized with an empty EDS value.

Refs

Depends on #1114
@Wondertan Wondertan mentioned this issue Sep 15, 2022
Closed
45 tasks
@Wondertan Wondertan added the area:shares Shares and samples label Sep 15, 2022
@distractedm1nd distractedm1nd mentioned this issue Nov 30, 2022
Merged
5 tasks
distractedm1nd added a commit that referenced this issue Dec 20, 2022
@distractedm1nd
feat(share): Ensure empty CAR exists in eds.Store (#1409)
0c26695 
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Closes #1113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:shares Shares and samples
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(share): Ensure empty CAR exists in eds.Store distractedm1nd/celestia-node
1 participant
@Wondertan