feat(share): eds.Blockstore #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
area:shares
distractedm1nd
requested review from
renaynay,
Wondertan and
vgonkivs
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1395 +/- ##
==========================================
- Coverage 55.28% 55.22% -0.06%
==========================================
Files 180 182 +2
Lines 10904 11074 +170
==========================================
+ Hits 6028 6116 +88
- Misses 4276 4344 +68
- Partials 600 614 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
walldiss
reviewed
Nov 24, 2022
Wondertan
reviewed
Nov 29, 2022
walldiss
reviewed
Nov 29, 2022
5 tasks
renaynay
reviewed
Nov 30, 2022
distractedm1nd
force-pushed
the
blockstore
branch
2 times, most recently
from
25f7205
to
c695d79
Compare
Wondertan
reviewed
Dec 5, 2022
Wondertan
reviewed
Dec 6, 2022
Wondertan
reviewed
Dec 6, 2022
walldiss
previously approved these changes
Dec 6, 2022
distractedm1nd
dismissed stale reviews from walldiss and Wondertan
via
a591136
distractedm1nd
force-pushed
the
blockstore
branch
from
383bdd7
to
a591136
Compare
Wondertan
approved these changes
Dec 6, 2022
renaynay
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a blockstore to
eds.Store. It was extracted from the eds.Store scaffolding PR. Tests are still needed, so still in draft for now.Closes #1115, #1427
Checklist
Visual proof for any user facing features like CLI or documentation updatesNA