fix(rpc): fraud.Proof (un)marshalling and subscription as chan
#1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
kind:fix
distractedm1nd
requested review from
renaynay,
Wondertan and
vgonkivs
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
- Coverage 55.81% 54.57% -1.24%
==========================================
Files 170 177 +7
Lines 10254 10595 +341
==========================================
+ Hits 5723 5782 +59
- Misses 3962 4239 +277
- Partials 569 574 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
distractedm1nd
force-pushed
the
fraudproof-marshaling
branch
from
6f75e7d
to
3a8b236
Compare
renaynay
requested changes
Nov 2, 2022
Wondertan
reviewed
Nov 2, 2022
walldiss
reviewed
Nov 2, 2022
renaynay
requested changes
Nov 3, 2022
Wondertan
requested changes
Nov 8, 2022
renaynay
reviewed
Nov 8, 2022
Wondertan
reviewed
Nov 8, 2022
|
Note to myself: create an issue to avoid double (un)marshaling of Proof |
8 tasks
distractedm1nd
force-pushed
the
fraudproof-marshaling
branch
from
fb2fcac
to
9c664eb
Compare
renaynay
previously approved these changes
Nov 10, 2022
|
Now closes #1303 as well. |
renaynay
previously approved these changes
Nov 10, 2022
Wondertan
previously approved these changes
Nov 10, 2022
distractedm1nd
dismissed stale reviews from Wondertan and renaynay
via
6e9a4af
Wondertan
previously approved these changes
Nov 10, 2022
distractedm1nd
force-pushed
the
fraudproof-marshaling
branch
from
6e9a4af
to
041cf6d
Compare
Wondertan
approved these changes
Nov 10, 2022
renaynay
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1208 (when combined with #1292), and closes #1207. Also closes #1303