feat(rpc): tooling for openrpc spec autogeneration #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
distractedm1nd
force-pushed
the
jsonrpc-docs
branch
from
093294c
to
be815d1
Compare
distractedm1nd
requested review from
renaynay,
Wondertan and
vgonkivs
as code owners
distractedm1nd
force-pushed
the
jsonrpc-docs
branch
2 times, most recently
from
e28a28a
to
164ed9a
Compare
distractedm1nd
force-pushed
the
jsonrpc-docs
branch
2 times, most recently
from
8223fc7
to
a033607
Compare
Wondertan
reviewed
Nov 9, 2022
distractedm1nd
force-pushed
the
jsonrpc-docs
branch
from
a033607
to
71a3436
Compare
Wondertan
previously approved these changes
Nov 11, 2022
vgonkivs
previously approved these changes
Nov 14, 2022
There was a problem hiding this comment.
LGTM, but I agree with @Wondertan , we should remove building docgen in makefile
distractedm1nd
dismissed stale reviews from vgonkivs and Wondertan
via
b481070
distractedm1nd
force-pushed
the
jsonrpc-docs
branch
from
71a3436
to
b481070
Compare
Codecov Report
@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
- Coverage 55.06% 54.86% -0.21%
==========================================
Files 178 178
Lines 10689 10689
==========================================
- Hits 5886 5864 -22
- Misses 4227 4248 +21
- Partials 576 577 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wondertan
previously approved these changes
Nov 15, 2022
|
@distractedm1nd, small conflict |
renaynay
previously approved these changes
Nov 16, 2022
distractedm1nd
dismissed stale reviews from renaynay and Wondertan
via
856d352
distractedm1nd
force-pushed
the
jsonrpc-docs
branch
from
b481070
to
856d352
Compare
renaynay
approved these changes
Nov 16, 2022
Wondertan
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1188
First prototype:
NOTE: finishing this will be its own PR)Long term(not this PR, issues to be created):