Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix goreleaser check deprecation warning #3795

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 19, 2024

Closes #3793 by resolving this deprecation notice

@rootulp rootulp self-assigned this Aug 19, 2024
@rootulp rootulp added backport:v1.x PR will be backported automatically to the v1.x branch upon merging backport:v2.x PR will be backported automatically to the v2.x branch upon merging labels Aug 19, 2024
@rootulp rootulp marked this pull request as ready for review August 19, 2024 20:40
@rootulp rootulp requested a review from a team as a code owner August 19, 2024 20:40
@rootulp rootulp requested review from cmwaters and ninabarbakadze and removed request for a team August 19, 2024 20:40
Copy link
Contributor

coderabbitai bot commented Aug 19, 2024

Walkthrough

Walkthrough

The recent changes to the .goreleaser.yaml configuration file involve a key modification in the snapshot section, where name_template has been replaced with version_template. This adjustment refines the naming convention for snapshots, ensuring that the configuration accurately reflects its intended purpose of versioning. The change aims to resolve issues related to the goreleaser-check process.

Changes

File Change Summary
.goreleaser.yaml Changed name_template to version_template for snapshots.

Assessment against linked issues

Objective Addressed Explanation
Fix goreleaser-check failure (#3793)

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 02b604d and b127caf.

Files selected for processing (1)
  • .goreleaser.yaml (1 hunks)
Additional comments not posted (1)
.goreleaser.yaml (1)

111-111: Change aligns with deprecation notice.

The modification from name_template to version_template in the snapshot section is correct and aligns with the deprecation notice from GoReleaser. This change should resolve the associated deprecation warning in the CI pipeline.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@rootulp rootulp enabled auto-merge (squash) August 20, 2024 14:16
@rootulp rootulp merged commit 02f0825 into celestiaorg:main Aug 20, 2024
34 checks passed
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
@rootulp rootulp deleted the rp/fix-goreleaser-check branch August 20, 2024 17:31
rootulp added a commit that referenced this pull request Aug 20, 2024
Closes #3793 by
resolving this [deprecation
notice](https://goreleaser.com/deprecations/#snapshotname_template)<hr>This
is an automatic backport of pull request #3795 done by
[Mergify](https://mergify.com).

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging backport:v2.x PR will be backported automatically to the v2.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goreleaser-check failure
3 participants