Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goreleaser-cross doesn't support version_template #3805

Closed
rootulp opened this issue Aug 22, 2024 · 0 comments · Fixed by #3806
Closed

goreleaser-cross doesn't support version_template #3805

rootulp opened this issue Aug 22, 2024 · 0 comments · Fixed by #3806
Assignees
@rootulp
Labels
bug Something isn't working

Comments

@rootulp
Copy link
Collaborator

rootulp commented Aug 22, 2024 •
edited
Loading

Problem

Goreleaser failed to publish binaries on v2.1.1 because https://github.com/celestiaorg/celestia-app/actions/runs/10497069730/job/29079086420#step:6:66

Proposal

Fix it
@rootulp rootulp added the bug Something isn't working label Aug 22, 2024
@rootulp rootulp self-assigned this Aug 22, 2024
@rootulp rootulp mentioned this issue Aug 22, 2024
Merged
rootulp added a commit that referenced this issue Aug 22, 2024
@rootulp
ci: use goreleaser-cross for goreleaser-check command (#3806)
13f3098 
Closes #3805

[goreleaser
v2.2.0](https://github.com/goreleaser/goreleaser/releases/tag/v2.2.0)
deprecated the `name_template` field in favor of `version_template`. Our
goreleaser-check command used a GH action that was using goreleaser
v2.2.0 so we fixed the deprecation in
#3797 but the make
prebuilt-binary command uses goreleaser-cross which was using a previous
version of goreleaser that fails for the new field.

This PR updates the goreleaser-check command to use the goreleaser-cross
Docker image so that the check command and prebuilt-binary command uses
the same version.

Note: we'll need to update `name_template` to `version_template` when we
upgrade to Go 1.23.0 because that will use goreleaser-cross 1.23.0 which
bumped to goreleaser 2.22.0. See
goreleaser/goreleaser-cross#77
mergify bot pushed a commit that referenced this issue Aug 22, 2024
@rootulp @mergify
ci: use goreleaser-cross for goreleaser-check command (#3806)
4430a94 
Closes #3805

[goreleaser
v2.2.0](https://github.com/goreleaser/goreleaser/releases/tag/v2.2.0)
deprecated the `name_template` field in favor of `version_template`. Our
goreleaser-check command used a GH action that was using goreleaser
v2.2.0 so we fixed the deprecation in
#3797 but the make
prebuilt-binary command uses goreleaser-cross which was using a previous
version of goreleaser that fails for the new field.

This PR updates the goreleaser-check command to use the goreleaser-cross
Docker image so that the check command and prebuilt-binary command uses
the same version.

Note: we'll need to update `name_template` to `version_template` when we
upgrade to Go 1.23.0 because that will use goreleaser-cross 1.23.0 which
bumped to goreleaser 2.22.0. See
goreleaser/goreleaser-cross#77

(cherry picked from commit 13f3098)
@mergify mergify bot mentioned this issue Aug 22, 2024
Merged
rootulp added a commit that referenced this issue Aug 22, 2024
@mergify @rootulp
ci: use goreleaser-cross for goreleaser-check command (backport #3806) (
48173df 
#3813)

Closes #3805

[goreleaser
v2.2.0](https://github.com/goreleaser/goreleaser/releases/tag/v2.2.0)
deprecated the `name_template` field in favor of `version_template`. Our
goreleaser-check command used a GH action that was using goreleaser
v2.2.0 so we fixed the deprecation in
#3797 but the make
prebuilt-binary command uses goreleaser-cross which was using a previous
version of goreleaser that fails for the new field.

This PR updates the goreleaser-check command to use the goreleaser-cross
Docker image so that the check command and prebuilt-binary command uses
the same version.

Note: we'll need to update `name_template` to `version_template` when we
upgrade to Go 1.23.0 because that will use goreleaser-cross 1.23.0 which
bumped to goreleaser 2.22.0. See
https://github.com/goreleaser/goreleaser-cross/pull/77<hr>This is an
automatic backport of pull request #3806 done by
[Mergify](https://mergify.com).

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: use goreleaser-cross for goreleaser-check command rootulp/celestia-app
1 participant
@rootulp