-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement breadth-triggered Horizons #199
Conversation
Check-perf-impact results: (9e900a306dc9f17e4a27439205a7680c) ❓ No new benchmark data submitted. ❓ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've been looking forward to this.
A few requests nonetheless.
9ff3b29
to
ba0afea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
ba0afea
to
7911331
Compare
This should now be ready for re-review. |
7911331
to
005c547
Compare
Check-perf-impact results: (7a518c63eb0655471fea6a4902fc0af7)
Overall relative execution time: 1.00x (mean of relative medians) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've added a few minor notes!
005c547
to
32b048e
Compare
32b048e
to
712f277
Compare
712f277
to
8c0779c
Compare
This implements Horizons which are triggered when the breadth of the execution front exceeds a given limit, which can be configured at runtime (currently defaults to
64
).This also makes it impossible to run out of task slots in normal usage (i.e. unless the user manually sets the limit to a value that exceeds the task ring buffer capacity).
This PR includes #196 and #197 which should be merged first, and is actually rather small by itself.
I will rebase it once those are merged.