Fix behaviour of fence and horizons in dry runs #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check-perf-impact results: (9e900a306dc9f17e4a27439205a7680c) ❓ No new benchmark data submitted. ❓ |
|
(Note: this is currently failing due to our CI rework; will only merge after all of that is resolved) |
fknorr
approved these changes
Aug 9, 2023
PeterTh
changed the title
Also add a unit test and get rid of some utilities that are no longer necessary.
psalz
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a unit test.
Note that I very minorly changed the existing dry run test: it was the only test to still use
test_utils::set_test_env. Changing this to use the equivalentlibenvppfunctionality allowed me to get rid of the entireset_test_envtest utility (which even had platform-specific code), making this a -20 net LoC change. Yay!Edit:
Also fixed processing of horizons in dry runs and added a test for that.