-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark TDAG/CDAG generation in isolation #107
Conversation
ec5b728
to
7b9f1cf
Compare
I have simplified the implementation of benchmark tree graph generation and introduced more complex communication patterns. The correctness of the generated graphs can be verified through the |
da20e27
to
5c77d70
Compare
9abd694
to
e172340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! Given the precedent set by #100 this should also include updated benchmark results for ci/perf
.
2fd8290
to
5ad7bab
Compare
This PR is similar to #62 in that it benchmarks various graph topologies, however, it only measures graph generation and serialization as they happen on the master node without actually passing commands on to workers. It can therefore be evaluated on a single node and timed more precisely, but does not benchmark job generation or execution at all.
[task-graph]
benchmarks measure TDAG generation.[command-graph]
benchmarks measure TDAG + CDAG generation and serialization in the same thread[scheduler]
benchmarks are like[command-graph]
, but use a dedicated scheduler thread similar to the runtimeI shamelessly copied the artificial graph topologies from @PeterTh 's #62 and added real-world graph examples from
wave_sim
as well as an (imaginary) Jacobi solver implementation.Benchmarking the scheduler thread required some refactoring that allows re-using its
std::thread
in order to exclude the thread creation overhead from timings.