Replace std::list with small vector for dependency tracking #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterTh
force-pushed
the
list-refactor
branch
4 times, most recently
from
9ff8e8a to
b94a753
Compare
|
Note: as per to our previous team discussion, this should probably not be squashed, since it has the old benchmark results in the prior commit and the new ones with the change in the new commit. |
fknorr
reviewed
Mar 2, 2022
PeterTh
force-pushed
the
list-refactor
branch
3 times, most recently
from
7e8fff4 to
c34ec43
Compare
fknorr
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the use of
std::listfor dependency tracking withgch::small_vector, and introduces some microbenchmarks for it.The only other active use of
std::listin celerity is in the buffer transfer manager, but all operations on those also seem to involve the network eventually, so micro-optimizing that doesn't appear to make much sense.Microbenchmark results in graphical form are available here.