[memcache] Add multi-instance support for memcache (DataDog#318)

manifests/integrations/memcache.pp

@@ -19,19 +19,45 @@
 #   url      => 'localhost',
 # }
 #
+#
+# Sample Usage (Instance):
+#  class { 'datadog_agent::integrations::memcache' :
+#    instances => [{
+#      url   => 'localhost',
+#      port  => '11211',
+#      items => false,
+#      slabs => false,
+#    }]
+#  }
+#
 class datadog_agent::integrations::memcache (
   $url                    = 'localhost',
   $port                   = 11211,
   $tags                   = [],
   $items                  = false,
   $slabs                  = false,
+  $instances = undef,
 ) inherits datadog_agent::params {
   include datadog_agent
 
   validate_string($url)
   validate_array($tags)
   validate_integer($port)
 
+  if !$instances and $url {
+    $_instances = [{
+      'url'   => $url,
+      'port'  => $port,
+      'tags'  => $tags,
+      'items' => $items,
+      'slabs' => $slabs,
+    }]
+  } elsif !$instances{
+    $_instances = []
+  } else {
+    $_instances = $instances
+  }
+
   file { "${datadog_agent::params::conf_dir}/mcache.yaml":
     ensure  => file,
     owner   => $datadog_agent::params::dd_user,

spec/classes/datadog_agent_integrations_memcache_spec.rb

@@ -17,6 +17,7 @@
     group: dd_group,
     mode: '0600',
   )}
+
   it { should contain_file(conf_file).that_requires("Package[#{dd_package}]") }
   it { should contain_file(conf_file).that_notifies("Service[#{dd_service}]") }
 
@@ -62,7 +63,6 @@
       let(:params) {{
         tags: [ 'foo', '', 'baz' ]
       }}
-
       it { should contain_file(conf_file).with_content(/tags:\s+- foo\s+- baz\s*?[^-]/m) }
     end
 
@@ -82,4 +82,40 @@
       skip("doubly undefined behavior")
     end
   end
+
+  context 'with multiple instances set' do
+    let(:params) {
+      {
+        instances: [
+          {
+            'url'   => 'localhost',
+            'port'  => '11211',
+            'items' => true,
+            'slabs' => true,
+            'tags'  => ['tag1:value1'],
+          },
+          {
+            'url'   => 'foo.bar',
+            'port'  => '11212',
+            'items' => false,
+            'slabs' => false,
+            'tags'  => ['tag2:value2'],
+          }
+        ]
+      }
+    }
+    it { should contain_file(conf_file).with_content(%r{instances:}) }
+    it { should contain_file(conf_file).with_content(%r{  - url: localhost}) }
+    it { should contain_file(conf_file).with_content(%r{    port: 11211}) }
+    it { should contain_file(conf_file).with_content(%r{    items: true}) }
+    it { should contain_file(conf_file).with_content(%r{    slabs: true}) }
+    it { should contain_file(conf_file).with_content(%r{    tags:}) }
+    it { should contain_file(conf_file).with_content(%r{      - tag1:value1}) }
+    it { should contain_file(conf_file).with_content(%r{  - url: foo.bar}) }
+    it { should contain_file(conf_file).with_content(%r{    port: 11212}) }
+    it { should contain_file(conf_file).with_content(%r{    items: false}) }
+    it { should contain_file(conf_file).with_content(%r{    slabs: false}) }
+    it { should contain_file(conf_file).with_content(%r{    tags:}) }
+    it { should contain_file(conf_file).with_content(%r{      - tag2:value2}) }
+  end
 end

templates/agent-conf.d/mcache.yaml.erb

@@ -1,17 +1,23 @@
+#
+# MANAGED BY PUPPET
+#
+
 init_config:
 
 instances:
-    -   url: <%= @url %>
-        port: <%= @port %>
-<% if @tags and ! @tags.empty? -%>
-        tags:
-  <%- Array(@tags).each do |tag| -%>
+<%- (Array(@_instances)).each do |instance| -%>
+  - url: <%= instance['url'] %>
+    port: <%= instance['port'] %>
+<% if instance['tags'] and ! instance['tags'].empty? -%>
+    tags:
+  <%- Array(instance['tags']).each do |tag| -%>
     <%- if tag != '' -%>
-            - <%= tag %>
+      - <%= tag %>
     <%- end -%>
   <%- end -%>
 <% end -%>
 
-options:
-  items: <%= @items %>
-  slabs: <%= @slabs %>
+    options:               # Optional
+        items: <%= instance['items'] %>
+        slabs: <%= instance['slabs'] %>
+<% end -%>