-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[memcache] Add multi-instance support for memcache #318
[memcache] Add multi-instance support for memcache #318
Conversation
Hi @npaufler could you please rebase to the latest
Thank you! I'll take a look at this ASAP. |
b4f73c8
to
8574603
Compare
Sorry for the delay, @truthbk - was traveling late last week. I've rebased against the most recent master and pushed it up. Thanks |
@npaufler as we discussed on slack, any chance you'll be able to write those juicy tests :) Let me know if you need anything! Existing tests are ✅ so that's promising, but if we could add one for a multi-instance config, that'd be great. |
It was on my to do list for this week but it unfortunately some other things came up. Hoping to take a look this weekend or early next week :) Thanks for checking in |
@npaufler we'll be releasing |
36ad8b1
to
53fe888
Compare
@truthbk Done - specs are now in place for the mcache improvements. |
53fe888
to
d4d172f
Compare
d4d172f
to
ee27268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🍰
Added multiple-instance support for memcache (similar to the implementation for the MySQL integration).