Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memcache] Add multi-instance support for memcache #318

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

npaufler
Copy link
Contributor

Added multiple-instance support for memcache (similar to the implementation for the MySQL integration).

@truthbk
Copy link
Member

truthbk commented Apr 19, 2017

Hi @npaufler could you please rebase to the latest master? After bringing in the latest changes to your forked repo:

git checkout master
git pull
git checkout 20170331-memcache-multi-instance
git rebase master
git push -f origin 20170331-memcache-multi-instance

Thank you! I'll take a look at this ASAP.

@npaufler npaufler force-pushed the 20170331-memcache-multi-instance branch from b4f73c8 to 8574603 Compare April 24, 2017 14:09
@npaufler
Copy link
Contributor Author

Sorry for the delay, @truthbk - was traveling late last week. I've rebased against the most recent master and pushed it up.

Thanks

@truthbk
Copy link
Member

truthbk commented May 5, 2017

@npaufler as we discussed on slack, any chance you'll be able to write those juicy tests :) Let me know if you need anything! Existing tests are ✅ so that's promising, but if we could add one for a multi-instance config, that'd be great.

@npaufler
Copy link
Contributor Author

npaufler commented May 5, 2017

It was on my to do list for this week but it unfortunately some other things came up. Hoping to take a look this weekend or early next week :)

Thanks for checking in

@truthbk truthbk self-requested a review May 11, 2017 14:24
@truthbk truthbk added this to the 1.11.0 milestone May 11, 2017
@truthbk
Copy link
Member

truthbk commented Jul 20, 2017

@npaufler we'll be releasing 1.11.0 sooner rather than later, so if you could give those spec tests a shot, so we can merge and release this, that would be fantastic. Let me know if you have any questions.

@npaufler npaufler force-pushed the 20170331-memcache-multi-instance branch 2 times, most recently from 36ad8b1 to 53fe888 Compare July 21, 2017 01:49
@npaufler
Copy link
Contributor Author

@truthbk Done - specs are now in place for the mcache improvements.

@npaufler npaufler force-pushed the 20170331-memcache-multi-instance branch from 53fe888 to d4d172f Compare July 21, 2017 02:12
@npaufler npaufler force-pushed the 20170331-memcache-multi-instance branch from d4d172f to ee27268 Compare July 21, 2017 13:56
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🍰

@truthbk truthbk merged commit 977b70b into DataDog:master Jul 21, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants