Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use flag #1516

Merged
merged 23 commits into from
Jan 13, 2023
Merged

Update use flag #1516

merged 23 commits into from
Jan 13, 2023

Conversation

timarney
Copy link
Member

@timarney timarney commented Jan 10, 2023

Summary | Résumé

Test instructions | Instructions pour tester la modification

  • Test login page
  • Ensure the Form is working properly

Unresolved questions / Out of scope | Questions non résolues ou hors sujet

  • Opted not to utilize isLoading for the login page --- as the UI being conditional without a loader seems fine

Pull Request Checklist

Please complete the following items in the checklist before you request a review:

  • Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
  • The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
  • If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
  • Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
  • Does your code have adequate comprehensible comments? Do new functions have docstrings?
  • Have you modified the change log and updated any relevant documentation?
  • Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
  • If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

@github-actions
Copy link
Contributor

@timarney timarney marked this pull request as ready for review January 11, 2023 15:38
Copy link
Contributor

@bryan-robitaille bryan-robitaille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timarney timarney merged commit 7e537a8 into develop Jan 13, 2023
@timarney timarney deleted the update-use-flag branch January 13, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants