Add use load flag + isLoading status #1512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
swr
to latest package versionPrior to adding the isLoading variable the pages would briefly show the content as if the flag was off i.e.
Registration is closed at this time
.With the updated flag check we can show a spinner prior to getting the status back.
Test instructions | Instructions pour tester la modification
/signup/register
--- watch the loading progressUnresolved questions / Out of scope | Questions non résolues ou hors sujet
@bryan-robitaille if we're happy with this approached I will update the other files that are using
useFlag
. I also opted not to pass the suspensetrue
option for now ... some interesting discussion here: vercel/swr#1906Pull Request Checklist
Please complete the following items in the checklist before you request a review: